From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id C67D83847832 for ; Wed, 26 May 2021 18:20:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C67D83847832 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-237-t-xHVPGoMP2juATSO5RUWw-1; Wed, 26 May 2021 14:20:57 -0400 X-MC-Unique: t-xHVPGoMP2juATSO5RUWw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 639B81052BA4; Wed, 26 May 2021 18:20:56 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-113-228.ams2.redhat.com [10.36.113.228]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8DE9B5D6D3; Wed, 26 May 2021 18:20:55 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella via Libc-alpha Subject: Re: [PATCH 08/11] nptl: Move cancel state out of cancelhandling References: <20210526165728.1772546-1-adhemerval.zanella@linaro.org> <20210526165728.1772546-9-adhemerval.zanella@linaro.org> Date: Wed, 26 May 2021 20:20:53 +0200 In-Reply-To: <20210526165728.1772546-9-adhemerval.zanella@linaro.org> (Adhemerval Zanella via Libc-alpha's message of "Wed, 26 May 2021 13:57:25 -0300") Message-ID: <87y2c1pda2.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 May 2021 18:21:00 -0000 * Adhemerval Zanella via Libc-alpha: > diff --git a/nptl/descr.h b/nptl/descr.h > index a120365f88..a3084fdf60 100644 > --- a/nptl/descr.h > +++ b/nptl/descr.h > @@ -407,6 +401,10 @@ struct pthread > /* Used on strsignal. */ > struct tls_internal_t tls_state; > > + /* Thread cancel state (PTHREAD_CANCEL_ENABLE or > + PTHREAD_CANCEL_DISABLE). */ > + unsigned char cancelstate; You could move this into the padding after the c11 flag, I think. I think there is an implied dependency on PTHREAD_CANCEL_ENABLE == 0 in __tls_init_tp and somewhere in pthread_create. Maybe add a static assert for PTHREAD_CANCEL_ENABLE == 0? Thanks, Florian