public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH v2] nptl: Fix tst-pthread-gdb-attach for ptrace_scope equal 1
Date: Fri, 14 May 2021 17:15:54 +0200	[thread overview]
Message-ID: <87y2chl51x.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20210512185312.938871-1-adhemerval.zanella@linaro.org> (Adhemerval Zanella via Libc-alpha's message of "Wed, 12 May 2021 15:53:12 -0300")

* Adhemerval Zanella via Libc-alpha:

> +  /* Run 'gdb' on test subprocess which will be created in gdb_process.
> +     The pid of the subprocess will be written to 'tested_pid'.  */
> +  pid_t *tested_pid = (pid_t *) xmmap (NULL, sizeof (pid_t),
> +                                       PROT_READ | PROT_WRITE,
> +                                       MAP_SHARED | MAP_ANONYMOUS, -1);


We have support_shared_allocate for this.  Rest looks okay.

Thanks,
Florian


      parent reply	other threads:[~2021-05-14 15:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-12 17:49 [PATCH] " Adhemerval Zanella
2021-05-12 17:58 ` Florian Weimer
2021-05-12 18:53   ` [PATCH v2] " Adhemerval Zanella
2021-05-12 18:59     ` Adhemerval Zanella
2021-05-14 12:48     ` Adhemerval Zanella
2021-05-14 15:15     ` Florian Weimer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y2chl51x.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).