From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 0524D3857423 for ; Wed, 5 May 2021 15:30:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 0524D3857423 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-555-Y0Upi2NeMIuuCtPMsQIOcA-1; Wed, 05 May 2021 11:30:36 -0400 X-MC-Unique: Y0Upi2NeMIuuCtPMsQIOcA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8FE8210066E6; Wed, 5 May 2021 15:30:35 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-112-137.ams2.redhat.com [10.36.112.137]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B689560C17; Wed, 5 May 2021 15:30:34 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Subject: Re: [PATCH 04/11] nptl: Move sem_close, sem_open into libc References: <2901c489-d949-bade-cb81-0ef35cdf261a@linaro.org> Date: Wed, 05 May 2021 17:30:51 +0200 In-Reply-To: <2901c489-d949-bade-cb81-0ef35cdf261a@linaro.org> (Adhemerval Zanella's message of "Wed, 5 May 2021 11:33:52 -0300") Message-ID: <87y2ctdwpg.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 May 2021 15:30:40 -0000 * Adhemerval Zanella: > On 03/05/2021 10:51, Florian Weimer via Libc-alpha wrote: >> The symbols were moved using move-symbol-to-libc.py. >> >> Both functions are moved at the same time because they depend >> on internal functions in sysdeps/pthread/sem_routines.c, which >> are moved in this commit as well. Additional hidden prototypes >> are required to avoid check-localplt failures. > > LGTM, with some small nits below. > > Reviewed-by: Adhemerval Zanella Thanks, I've applied these suggestions. Florian