From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 50EA2386F839 for ; Fri, 19 Mar 2021 20:29:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 50EA2386F839 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-19-RFVffeMTPhSPjOqrc8RdCg-1; Fri, 19 Mar 2021 16:29:37 -0400 X-MC-Unique: RFVffeMTPhSPjOqrc8RdCg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 427341966322; Fri, 19 Mar 2021 20:29:36 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-112-80.ams2.redhat.com [10.36.112.80]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5D6F22AF44; Fri, 19 Mar 2021 20:29:35 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Subject: Re: [RFC 2/2] Fold compat_symbol_unique functionality into compat_symbol References: <965a0d7e0c28a5a0ce292a2b0bd39f2ba31d1a84.1616095061.git.fweimer@redhat.com> <37e68057-c3be-b522-98a3-1837b02c490a@linaro.org> <8735wqj3ub.fsf@oldenburg.str.redhat.com> Date: Fri, 19 Mar 2021 21:29:45 +0100 In-Reply-To: (Adhemerval Zanella's message of "Fri, 19 Mar 2021 17:26:52 -0300") Message-ID: <87y2eihop2.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Mar 2021 20:29:40 -0000 * Adhemerval Zanella: > The __attribute__ ((nocommon)) on the malloc hook fixed the build issue. I've fixed this locally, and also added to versioned_symbol: If LOCAL is a data symbol and does not have a non-zero initializer, it should be defined with __attribute__ ((nocommon)) for compatibility with GCC versions that default to -fcommon. */ Should I posted a v3? Thanks, Florian