From: Florian Weimer <fw@deneb.enyo.de>
To: "Alexandra Hájková via Libc-alpha" <libc-alpha@sourceware.org>
Cc: "Alexandra Hájková" <alexandra.khirnova@gmail.com>,
"Alexandra Hájková" <ahajkova@redhat.com>
Subject: Re: [PATCH] Add xfchmod to libsupport
Date: Sat, 09 Jan 2021 18:30:40 +0100 [thread overview]
Message-ID: <87y2h2f267.fsf@mid.deneb.enyo.de> (raw)
In-Reply-To: <20201228201329.2151654-1-ahajkova@redhat.com> ("Alexandra =?iso-8859-1?Q?H=E1jkov=E1?= via Libc-alpha"'s message of "Mon, 28 Dec 2020 21:13:29 +0100")
* Alexandra Hájková via Libc-alpha:
> diff --git a/support/xfchmod.c b/support/xfchmod.c
> new file mode 100644
> index 0000000000..4a6daa99e2
> --- /dev/null
> +++ b/support/xfchmod.c
> @@ -0,0 +1,28 @@
> +/* fchmod with error checking.
> + Copyright (C) 2020 Free Software Foundation, Inc.
The copyright year needs to be 2021 now.
> +xfchmod (int fd, mode_t mode)
> +{
> + if (fchmod (fd, mode) != 0)
> + FAIL_EXIT1 ("mkdir (\"%d\", 0%o): %m", fd, mode);
> +}
Please fix the function name (should be "fchmod", not "mkdir"), and
remove the quotes around %d. Rest looks fine.
next prev parent reply other threads:[~2021-01-09 17:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-28 20:13 Alexandra Hájková
2021-01-09 17:30 ` Florian Weimer [this message]
2021-01-09 19:31 ` Alexandra Hájková
2021-01-09 21:25 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2h2f267.fsf@mid.deneb.enyo.de \
--to=fw@deneb.enyo.de \
--cc=ahajkova@redhat.com \
--cc=alexandra.khirnova@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).