From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by sourceware.org (Postfix) with ESMTP id EDA7E386F83F for ; Thu, 28 May 2020 11:38:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org EDA7E386F83F Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-20-8zYAk6uJMBq5ILIy1fRD5g-1; Thu, 28 May 2020 07:38:08 -0400 X-MC-Unique: 8zYAk6uJMBq5ILIy1fRD5g-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3320B873015; Thu, 28 May 2020 11:38:07 +0000 (UTC) Received: from oldenburg2.str.redhat.com (ovpn-112-91.ams2.redhat.com [10.36.112.91]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8109460C81; Thu, 28 May 2020 11:38:06 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella via Libc-alpha Subject: Re: [PATCH 05/13] string: Remove old TLS usage on strsignal References: <20200519180518.318733-1-adhemerval.zanella@linaro.org> <20200519180518.318733-6-adhemerval.zanella@linaro.org> Date: Thu, 28 May 2020 13:38:04 +0200 In-Reply-To: <20200519180518.318733-6-adhemerval.zanella@linaro.org> (Adhemerval Zanella via Libc-alpha's message of "Tue, 19 May 2020 15:05:10 -0300") Message-ID: <87y2pccmsj.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-13.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 May 2020 11:38:11 -0000 * Adhemerval Zanella via Libc-alpha: > The per-thread state is refactored two use two strategies: > > 1. The default one uses a TLS structure, which will be place in the > static TLS space (using __thread keyword). > > 2. Linux allocates on struct pthread and access it through THREAD_* > macros. Hurd can use the same infrastructure nowadays, since commit b65a82e4e757c1e6cb7073916a29 ("hurd: Add THREAD_GET/SETMEM/_NC"). I'm not sure if struct tls_internal_t is necessary at this point. > diff --git a/malloc/thread-freeres.c b/malloc/thread-freeres.c > index c71ca4fc33..d42eea770b 100644 > --- a/malloc/thread-freeres.c > +++ b/malloc/thread-freeres.c > @@ -32,6 +32,7 @@ __libc_thread_freeres (void) > call_function_static_weak (__rpc_thread_destroy); > call_function_static_weak (__res_thread_freeres); > call_function_static_weak (__strerror_thread_freeres); > + call_function_static_weak (__strsignal_thread_freeres); I think you can call free directly. I doubt it increases binary size=E2=80=94the data is in the thread descriptor, so nothing needs to be p= ulled into the link for this. Thanks, Florian