From: Florian Weimer <fw@deneb.enyo.de>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH 6/7] linux: Refactor sched_getcpu in terms of getcpu
Date: Sun, 01 Dec 2019 14:22:00 -0000 [thread overview]
Message-ID: <87y2vwdt1g.fsf@mid.deneb.enyo.de> (raw)
In-Reply-To: <20191129210327.26434-6-adhemerval.zanella@linaro.org> (Adhemerval Zanella's message of "Fri, 29 Nov 2019 18:03:26 -0300")
* Adhemerval Zanella:
> diff --git a/sysdeps/unix/sysv/linux/sched_getcpu.c b/sysdeps/unix/sysv/linux/sched_getcpu.c
> index 65dd9fdda7..3646c8b713 100644
> --- a/sysdeps/unix/sysv/linux/sched_getcpu.c
> +++ b/sysdeps/unix/sysv/linux/sched_getcpu.c
> @@ -17,23 +17,11 @@
>
> #include <errno.h>
> #include <sched.h>
> -#include <sysdep.h>
> -
> -#ifdef HAVE_GETCPU_VSYSCALL
> -# define HAVE_VSYSCALL
> -#endif
> -#include <sysdep-vdso.h>
>
> int
> sched_getcpu (void)
> {
> -#ifdef __NR_getcpu
> unsigned int cpu;
> - int r = INLINE_VSYSCALL (getcpu, 3, &cpu, NULL, NULL);
> -
> + int r = __getcpu (&cpu, NULL);
> return r == -1 ? r : cpu;
> -#else
> - __set_errno (ENOSYS);
> - return -1;
> -#endif
> }
I wonder if the current state is a useful performance optimization.
next prev parent reply other threads:[~2019-12-01 14:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-29 21:03 [PATCH 1/7] linux: Update x86 vDSO symbols Adhemerval Zanella
2019-11-29 21:03 ` [PATCH 4/7] linux: Update mips " Adhemerval Zanella
2019-11-29 21:03 ` [PATCH 5/7] elf: Enable relro for static build Adhemerval Zanella
2019-12-01 9:55 ` Florian Weimer
2019-12-02 13:57 ` Adhemerval Zanella
2019-12-02 18:25 ` Florian Weimer
2019-12-02 18:54 ` Adhemerval Zanella
2019-12-02 19:03 ` Florian Weimer
2019-12-02 19:33 ` Adhemerval Zanella
2019-12-03 13:53 ` [PATCH v2] " Adhemerval Zanella
2019-11-29 21:03 ` [PATCH 2/7] x86: Make x32 use x86 time implementation Adhemerval Zanella
2019-11-29 21:03 ` [PATCH 7/7] elf: Move vDSO setup to rtld Adhemerval Zanella
2019-11-29 21:03 ` [PATCH 6/7] linux: Refactor sched_getcpu in terms of getcpu Adhemerval Zanella
2019-12-01 14:22 ` Florian Weimer [this message]
2019-12-02 14:00 ` Adhemerval Zanella
2019-12-03 13:56 ` [PATCH v2] linux: Add inline getcpu implementation for sched_getcpu and getcpu Adhemerval Zanella
2019-11-29 21:03 ` [PATCH 3/7] Remove vDSO support from make-syscall.sh Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2vwdt1g.fsf@mid.deneb.enyo.de \
--to=fw@deneb.enyo.de \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).