From: Florian Weimer <fweimer@redhat.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] Pass -nostdlib -nostartfiles together with -r [BZ #31753]
Date: Sun, 19 May 2024 21:24:33 +0200 [thread overview]
Message-ID: <87zfslvc3y.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20240518030038.622775-1-hjl.tools@gmail.com> (H. J. Lu's message of "Fri, 17 May 2024 20:00:38 -0700")
* H. J. Lu:
> Since -r in GCC 6/7/8 doesn't imply -nostdlib -nostartfiles, update the
> link-static-libc.out rule to also pass -nostdlib -nostartfiles. This
> fixes BZ #31753.
>
> Signed-off-by: H.J. Lu <hjl.tools@gmail.com>
> ---
> Makefile | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index adf4749124..c84f266ce7 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -581,7 +581,8 @@ $(objpfx)lint-makefiles.out: scripts/lint-makefiles.sh
> # definitions of any symbols.
> tests-special += $(objpfx)link-static-libc.out
> $(objpfx)link-static-libc.out:
> - $(LINK.o) $(whole-archive) -r $(objpfx)libc.a -o /dev/null > $@ 2>&1; \
> + $(LINK.o) $(whole-archive) -nostdlib -nostartfiles -r \
> + $(objpfx)libc.a -o /dev/null > $@ 2>&1; \
> $(evaluate-test)
>
> # Print test summary for tests in $1 .sum file;
Ahh, I was confused, this is actually a new test. The tst- prefix would
have helped.
Change looks good.
Reviewed-by: Florian Weimer <fweimer@redhat.com>
Thanks,
Florian
prev parent reply other threads:[~2024-05-19 19:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-18 3:00 H.J. Lu
2024-05-19 19:24 ` Florian Weimer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zfslvc3y.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=hjl.tools@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).