From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id CC0DF3858D1E for ; Sun, 19 May 2024 19:24:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CC0DF3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CC0DF3858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716146679; cv=none; b=G0P8+S4fqADuydt0UIEIz4KJyyHa4cUVZLWR/BkBZAzk85LqLZzFzvfHa5yyFN3whT26bK3YWxLryleomrHbxmQswAtGYJV/xKU/gNuHs7YxSbFFgyhT40WAh0Bfxg+Wqu6h83YER+BC3j8oGSE4tVo2UlBstjrlHaRyLtHAL3g= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716146679; c=relaxed/simple; bh=4/zuBUv+e81UkY+HocSplCO0azim/xcaPWp2A/p4W2A=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=JelTtOu0Ig1yYZt3Yywm8FnaYWivQPJ0yc95jhRmGrLNqzhYbrMRNxZ85cgUdNQpErmwqZRXWakEpiAfkPoJDzk446bwEWfpMDlmYbIs57dIWrtr4gi3riU2eA9ZJAQ01a5WIFh3pu5MvHVt4Cb3vg+piLB2JZOoQkitonpNh6c= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1716146677; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5zcRQeSbf9N3kOkeRQXuokRxzyifv8wqCAc77wgP558=; b=bd/Yde4Dmlq/LUmEHGiBkdF8g7Eq2TyswusnWd7p7iKrJYwAc6MSVEVDxwWkNHKkxmZjTF /KAeifZtfRR2YcXkVMTBKysmC35JYisqVjliSXkfFBP4YyZJwXScVw5yRFF3MU9//0w/rG PvE/t0xT0a2fF+T+kHc4PiZLdE34FDw= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-171-Lb50XQibNSOhvbhixGBrCw-1; Sun, 19 May 2024 15:24:36 -0400 X-MC-Unique: Lb50XQibNSOhvbhixGBrCw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BD157101A525; Sun, 19 May 2024 19:24:35 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.86]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0CECA105480A; Sun, 19 May 2024 19:24:34 +0000 (UTC) From: Florian Weimer To: "H.J. Lu" Cc: libc-alpha@sourceware.org Subject: Re: [PATCH] Pass -nostdlib -nostartfiles together with -r [BZ #31753] In-Reply-To: <20240518030038.622775-1-hjl.tools@gmail.com> (H. J. Lu's message of "Fri, 17 May 2024 20:00:38 -0700") References: <20240518030038.622775-1-hjl.tools@gmail.com> Date: Sun, 19 May 2024 21:24:33 +0200 Message-ID: <87zfslvc3y.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-10.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * H. J. Lu: > Since -r in GCC 6/7/8 doesn't imply -nostdlib -nostartfiles, update the > link-static-libc.out rule to also pass -nostdlib -nostartfiles. This > fixes BZ #31753. > > Signed-off-by: H.J. Lu > --- > Makefile | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index adf4749124..c84f266ce7 100644 > --- a/Makefile > +++ b/Makefile > @@ -581,7 +581,8 @@ $(objpfx)lint-makefiles.out: scripts/lint-makefiles.sh > # definitions of any symbols. > tests-special += $(objpfx)link-static-libc.out > $(objpfx)link-static-libc.out: > - $(LINK.o) $(whole-archive) -r $(objpfx)libc.a -o /dev/null > $@ 2>&1; \ > + $(LINK.o) $(whole-archive) -nostdlib -nostartfiles -r \ > + $(objpfx)libc.a -o /dev/null > $@ 2>&1; \ > $(evaluate-test) > > # Print test summary for tests in $1 .sum file; Ahh, I was confused, this is actually a new test. The tst- prefix would have helped. Change looks good. Reviewed-by: Florian Weimer Thanks, Florian