From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id BD571384DEF5 for ; Thu, 15 Feb 2024 14:49:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BD571384DEF5 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BD571384DEF5 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708008595; cv=none; b=WUwb62Z/YyJGEYb99M6fCw2kL/tR2K0WHnWEoSNdq0jFSYTCOjnx6HKYq7Q6FVgjPfkymkyUA9uvNDVgoa0UPTxpmypxTJa9TtWdskH4aaISgt5m+9G8m97+OwNCs4CloYay1I+PmHsts0NPjc03tXgaoW1qH8JMwRsbuL6ty7U= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708008595; c=relaxed/simple; bh=EFIKzbAg9XorRFfIiUfB9nJ9lMS9fMPuAP+g9qR6uAg=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=TvVn1tO5uklb4+OHKPMoI8ZoKaz1NrJKj1pkOyd/T8PdZnlWH7QoqlKX3cEjyngkBMmkYYOGZo/lXYEFA4y+4maRi7G8d2iDdE9+uwNnf9GIDgXLeE6+lVBTycCDM5VcQA0LIWA3+ab5rMeGZKMT2qc5Yu6RACd3xore8G35J20= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708008587; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type; bh=n/qJcDiHj3zQj2OvHIsz9ReBhlXQ1D1s3xvymYfHYsY=; b=HwjWvMC/4BWQGtU9s9cKipuJh1Fu6BDXklNCapVx+93G+AMWhZpeatWVboOJaEBujgywNd 9qADhpCrXpN+8Gez53LQJROs5RuRkiSBPLT9FPHnTX2P+fl8kFCN2vvi6YorZoXRC1EkMH L/w56rsrYhcRA5Jl25sfRVcUnls6jEI= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-332-MYx8MUpzM2uD5k3MfQuBJw-1; Thu, 15 Feb 2024 09:49:44 -0500 X-MC-Unique: MYx8MUpzM2uD5k3MfQuBJw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 67FEA1C05AEB; Thu, 15 Feb 2024 14:49:44 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.50]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E275B1C060B1; Thu, 15 Feb 2024 14:49:43 +0000 (UTC) From: Florian Weimer To: libc-alpha@sourceware.org Cc: Sam James Subject: [PATCH] i386: Use generic memrchr in libc (bug 31316) Date: Thu, 15 Feb 2024 15:49:42 +0100 Message-ID: <87zfw1aik9.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Before this change, we incorrectly use the SSE2 variant is the implementation, without checking that the system actually supports SSE2. Tested-by: Sam James --- sysdeps/i386/i686/multiarch/memrchr-c.c | 1 + sysdeps/i386/i686/multiarch/memrchr-sse2.S | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/sysdeps/i386/i686/multiarch/memrchr-c.c b/sysdeps/i386/i686/multiarch/memrchr-c.c index ef7bbbe792..20bfdf3af3 100644 --- a/sysdeps/i386/i686/multiarch/memrchr-c.c +++ b/sysdeps/i386/i686/multiarch/memrchr-c.c @@ -5,3 +5,4 @@ extern void *__memrchr_ia32 (const void *, int, size_t); #endif #include "string/memrchr.c" +strong_alias (__memrchr_ia32, __GI___memrchr) diff --git a/sysdeps/i386/i686/multiarch/memrchr-sse2.S b/sysdeps/i386/i686/multiarch/memrchr-sse2.S index d9dae04171..e123f87435 100644 --- a/sysdeps/i386/i686/multiarch/memrchr-sse2.S +++ b/sysdeps/i386/i686/multiarch/memrchr-sse2.S @@ -720,5 +720,4 @@ L(ret_null): ret END (__memrchr_sse2) -strong_alias (__memrchr_sse2, __GI___memrchr) #endif base-commit: 491e55beab7457ed310a4a47496f4a333c5d1032