From: Florian Weimer <fweimer@redhat.com>
To: "Cristian Rodríguez via Libc-alpha" <libc-alpha@sourceware.org>
Cc: "Cristian Rodríguez" <cristian@rodriguez.im>
Subject: Re: [PATCH 3/5] linux: Replace zero-length array with flexible-array member on inotify struct
Date: Thu, 22 Jun 2023 07:23:52 +0200 [thread overview]
Message-ID: <87zg4s3w9j.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20230621213444.2017-2-cristian@rodriguez.im> ("Cristian =?utf-8?Q?Rodr=C3=ADguez?= via Libc-alpha"'s message of "Wed, 21 Jun 2023 21:34:31 +0000")
* Cristian Rodríguez via Libc-alpha:
> Current kernel versions require a compiler supporting -std=gnu11
> and therefore supporting C99 flexible arrays. old versions require
> a c89 compiler supporting this feature as an extension.
Ugh, you are right:
commit 94dfc73e7cf4a31da66b8843f0b9283ddd6b8381
Author: Gustavo A. R. Silva <gustavoars@kernel.org>
Date: Wed Apr 6 19:36:51 2022 -0500
treewide: uapi: Replace zero-length arrays with flexible-array members
It's specifically targeting UAPI headers, so it's not a (harmless)
kernel-internal change.
Do you know if anyone has looked at the compatibility impact of this
change on C parsers? I'm not sure if we can do the same thing. In
particular, if kernel headers are not C89-compatible, we may have to add
kludges to our own headers that avoid including them in C89 mode.
Thanks,
Florian
next prev parent reply other threads:[~2023-06-22 5:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 21:34 [PATCH 2/5] include: Replace zero-length array "msg" with C99 flexible-array Cristian Rodríguez
2023-06-21 21:34 ` [PATCH 3/5] linux: Replace zero-length array with flexible-array member on inotify struct Cristian Rodríguez
2023-06-21 21:44 ` Cristian Rodríguez
2023-06-22 5:23 ` Florian Weimer [this message]
2023-06-23 15:57 ` Cristian Rodríguez
2023-06-21 21:34 ` [PATCH 4/5] linux: Replace zero-length array with flexible-array member on struct dirstream Cristian Rodríguez
2023-06-22 5:25 ` Florian Weimer
2023-06-23 15:56 ` Cristian Rodríguez
2023-06-21 21:34 ` [PATCH 5/5] stdio-common: Replace zero-length array with flexible-array member Cristian Rodríguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zg4s3w9j.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=cristian@rodriguez.im \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).