From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id BF5733857352 for ; Mon, 5 Jun 2023 18:20:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BF5733857352 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685989237; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BX0sLgH3AymOq5zYW7mZ4psgMgX1EFm7PKiQvG38DvU=; b=WZkEjTnIJnPHEnPU3R0DgDXe+3vXHk0rGFDRxR91l1kQxj8RI6g6VYqlSj1QWpRfEBPSOx H3kEY/KEbaw/YkZEw7CWb1mhmd0IDCNE6kIBbVJcuV0bupePmqpHpuMb8puZBwoLPAWKi5 MlvQTCH0YAFuCI0Q3d7BHFrLuuzt0U0= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-637-PX2aGYWtPPKsw56SVcIBNw-1; Mon, 05 Jun 2023 14:20:34 -0400 X-MC-Unique: PX2aGYWtPPKsw56SVcIBNw-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D597A811E78; Mon, 5 Jun 2023 18:20:33 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.2.16.27]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0A0DC4026E2; Mon, 5 Jun 2023 18:20:32 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Netto Cc: Adhemerval Zanella via Libc-alpha Subject: Re: [PATCH] linux: Split tst-ttyname References: <20230601174432.456518-1-adhemerval.zanella@linaro.org> <87pm6ayqzq.fsf@oldenburg.str.redhat.com> <3d708678-6d74-b527-2e50-89255fcd65d1@linaro.org> Date: Mon, 05 Jun 2023 20:20:31 +0200 In-Reply-To: <3d708678-6d74-b527-2e50-89255fcd65d1@linaro.org> (Adhemerval Zanella Netto's message of "Mon, 5 Jun 2023 14:14:46 -0300") Message-ID: <87zg5dydn4.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * Adhemerval Zanella Netto: > On 05/06/23 10:32, Florian Weimer wrote: >> * Adhemerval Zanella via Libc-alpha: >> >>> sysdeps/unix/sysv/linux/Makefile | 1 + >>> sysdeps/unix/sysv/linux/tst-ttyname-common.c | 416 ++++++++++++++ >>> .../unix/sysv/linux/tst-ttyname-namespace.c | 147 +++++ >>> sysdeps/unix/sysv/linux/tst-ttyname.c | 512 +----------------- >>> 4 files changed, 567 insertions(+), 509 deletions(-) >>> create mode 100644 sysdeps/unix/sysv/linux/tst-ttyname-common.c >>> create mode 100644 sysdeps/unix/sysv/linux/tst-ttyname-namespace.c >> >> I'd prefer if we could stop using the original tst-ttyname name for >> clarity. > > Do you mean for the new tst-ttyname-namespace or for tst-ttyname as well? > The test idea is really to check ttyname, so what exactly do you suggest > us to change? We've seen quite a few reports about tst-ttyname failures, and it would be nice if future reports would unambiguously refer to the split test. So perhaps tst-ttyname-direct? Thanks, Florian