From: Florian Weimer <fweimer@redhat.com>
To: Carlos O'Donell <carlos@redhat.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH v2] Detect ld.so and libc.so version inconsistency during startup
Date: Tue, 23 Aug 2022 23:36:41 +0200 [thread overview]
Message-ID: <87zgfuzlp2.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <bfc8ac7c-7b90-cae6-5daf-e71e61b17964@redhat.com> (Carlos O'Donell's message of "Tue, 23 Aug 2022 17:26:51 -0400")
* Carlos O'Donell:
> I can't see this causes serious problems crossing container, chroot or
> namespace boundaries because we load libc.so.6 early before doing any
> kind of transition. Where it might have impact is in the developer
> workflow and we can adjust as required.
dlmopen after chroot may now fail due to ABI mismatch, but I think this
is correct.
>> - [Add new features here]
>> +* The dynamic loader now prints an error message, "ld.so/libc.so
>> + mismatch detected (upgrade in progress?)" if it detects that the
>> + version of libc.so it loaded comes from a different build of glibc.
>> + The new configure option --with-extra-version-id can be used to
>> + specify an arbitrary string that affects the comptuation of the
>
> s/comptuation/computation/g
>> + /* Detect a libc.so loaded into this namespace. The
>> + __libc_early_init lookup below means that we have to do this
>> + after parsing the version data. */
>> + if (GL(dl_ns)[map->l_ns].libc_map == NULL
>> + && map->l_info[DT_SONAME] != NULL
>> + && strcmp (((const char *) D_PTR (map, l_info[DT_STRTAB])
>> + + map->l_info[DT_SONAME]->d_un.d_val), LIBC_SO) == 0)
>> + {
>> + /* Look up this symbol error to trigger a mismatch error before
>
> s/error//g
Both fixed and reposted. In the second case, I meant to type “early”.
Thanks,
Florian
prev parent reply other threads:[~2022-08-23 21:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-23 17:36 Florian Weimer
2022-08-23 19:13 ` Florian Weimer
2022-08-23 21:26 ` Carlos O'Donell
2022-08-23 21:36 ` Florian Weimer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgfuzlp2.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=carlos@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).