From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 5ACA538582AE for ; Thu, 4 Aug 2022 15:54:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5ACA538582AE Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-96-XSNU5uCxPT6K4VPsuqH6hw-1; Thu, 04 Aug 2022 11:54:07 -0400 X-MC-Unique: XSNU5uCxPT6K4VPsuqH6hw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 89D3A185A794; Thu, 4 Aug 2022 15:54:07 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.37]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E4BA41121314; Thu, 4 Aug 2022 15:54:06 +0000 (UTC) From: Florian Weimer To: Alejandro Colomar Cc: libc-alpha@sourceware.org Subject: Re: [PATCH] malloc: Correct the documentation of the top_pad default References: <87wnbojswh.fsf@oldenburg.str.redhat.com> <8e9489ac-6e1e-3376-82c9-03db78a6e3c4@gmail.com> Date: Thu, 04 Aug 2022 17:54:05 +0200 In-Reply-To: <8e9489ac-6e1e-3376-82c9-03db78a6e3c4@gmail.com> (Alejandro Colomar's message of "Thu, 4 Aug 2022 17:46:40 +0200") Message-ID: <87zggkhun6.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-10.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Aug 2022 15:54:10 -0000 * Alejandro Colomar: > Hi Florian, > > On 8/4/22 10:48, Florian Weimer via Libc-alpha wrote: >> DEFAULT_TOP_PAD is defined as 131072 in >> sysdeps/generic/malloc-machine.h. >> --- >> elf/dl-tunables.list | 1 + >> elf/tst-rtld-list-tunables.exp | 2 +- >> manual/tunables.texi | 2 +- >> 3 files changed, 3 insertions(+), 2 deletions(-) >> > > [...] > >> diff --git a/manual/tunables.texi b/manual/tunables.texi >> index 83cdcdac6d..ffd50a3fe2 100644 >> --- a/manual/tunables.texi >> +++ b/manual/tunables.texi >> @@ -143,7 +143,7 @@ number of bytes to retain when shrinking any of the arenas. This provides the >> necessary hysteresis in heap size such that excessive amounts of system calls >> can be avoided. >> -The default value of this tunable is @samp{0}. >> +The default value of this tunable is @samp{131072} (128 KB). > > I don't know how much glibc uses KB vs KiB, but I'd like to be > pedantic here and suggest using KiB (maybe this requires a global > change to keep consistency). See units(7). I checked the chapter used KB, but not KiB before this change, so I kept using KB. Maybe we should change all occurrences to KiB. Thanks, Florian