From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 7E1763858D1E for ; Tue, 26 Apr 2022 06:47:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7E1763858D1E Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-596-XDSaCNmWM8uYvbRrpO5arg-1; Tue, 26 Apr 2022 02:47:47 -0400 X-MC-Unique: XDSaCNmWM8uYvbRrpO5arg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 144FA803B22; Tue, 26 Apr 2022 06:47:46 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.193.187]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8DFB21402406; Tue, 26 Apr 2022 06:47:40 +0000 (UTC) From: Florian Weimer To: Fangrui Song via Libc-alpha Cc: Adhemerval Zanella , Alan Modra , Tulio Magno Quites Machado Filho , Fangrui Song Subject: Re: [PATCH v2] elf: Replace PI_STATIC_AND_HIDDEN with opposite HIDDEN_VAR_NEEDS_DYNAMIC_RELOC References: <20220425181652.2627618-1-maskray@google.com> Date: Tue, 26 Apr 2022 08:47:38 +0200 In-Reply-To: <20220425181652.2627618-1-maskray@google.com> (Fangrui Song via Libc-alpha's message of "Mon, 25 Apr 2022 11:16:52 -0700") Message-ID: <87zgk8l4s5.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Apr 2022 06:47:56 -0000 * Fangrui Song via Libc-alpha: > PI_STATIC_AND_HIDDEN indicates whether accesses to internal linkage > variables and hidden visibility variables in a shared object (ld.so) > need dynamic relocations (usually R_*_RELATIVE). PI (position > independent) in the macro name is a misnomer: a code sequence using GOT > is typically position-independent as well, but using dynamic relocations > does not meet the requirement. > > Not defining PI_STATIC_AND_HIDDEN is legacy and we expect that all new > ports will define PI_STATIC_AND_HIDDEN. Current ports defining > PI_STATIC_AND_HIDDEN are more than the opposite. Change the configure > default. > > No functional change. > > Note: HIDDEN_VAR_NEEDS_DYNAMIC_RELOC will be removed when Alan Modra's > powerpc64 static-pie work > (https://sourceware.org/pipermail/libc-alpha/2022-April/137987.html) > lands. > > Changes from v1: > * Correctly regenerate sysdeps/m68k/configure I can confirm that this still builds all targets. Thanks, Florian