From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id C82093857C4D for ; Wed, 13 Apr 2022 15:28:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C82093857C4D Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-230-EE-5IqL5NLm1b4vCfBT5xA-1; Wed, 13 Apr 2022 11:28:02 -0400 X-MC-Unique: EE-5IqL5NLm1b4vCfBT5xA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 91398803DB8; Wed, 13 Apr 2022 15:28:02 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.193.61]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E8E0BC1D38B; Wed, 13 Apr 2022 15:27:56 +0000 (UTC) From: Florian Weimer To: Stefan Liebler via Libc-alpha Cc: Stefan Liebler Subject: Re: [PATCH] S390: Add new s390 platform z16. References: <20220413123609.1962983-1-stli@linux.ibm.com> Date: Wed, 13 Apr 2022 17:27:55 +0200 In-Reply-To: <20220413123609.1962983-1-stli@linux.ibm.com> (Stefan Liebler via Libc-alpha's message of "Wed, 13 Apr 2022 14:36:09 +0200") Message-ID: <87zgkp2ebo.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Apr 2022 15:28:09 -0000 * Stefan Liebler via Libc-alpha: > @@ -63,9 +64,11 @@ compute_level (void) > return 12; > if (strcmp (platform, "z15") == 0) > return 13; > + if (strcmp (platform, "z16") == 0) > + return 14; > printf ("warning: unrecognized AT_PLATFORM value: %s\n", platform); > /* Assume that the new platform supports z15. */ > - return 13; > + return 14; z15 in the comment needs updating. Rest looks okay to me. Thanks, Florian