From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 9A73F3858D28 for ; Fri, 8 Apr 2022 22:32:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9A73F3858D28 Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 238Ivhqo015294 for ; Fri, 8 Apr 2022 22:32:49 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 3faeu9tr67-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 08 Apr 2022 22:32:49 +0000 Received: from m0098410.ppops.net (m0098410.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 238MT92r018426 for ; Fri, 8 Apr 2022 22:32:49 GMT Received: from ppma01wdc.us.ibm.com (fd.55.37a9.ip4.static.sl-reverse.com [169.55.85.253]) by mx0a-001b2d01.pphosted.com with ESMTP id 3faeu9tr5y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 08 Apr 2022 22:32:49 +0000 Received: from pps.filterd (ppma01wdc.us.ibm.com [127.0.0.1]) by ppma01wdc.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 238M79jk020309; Fri, 8 Apr 2022 22:32:48 GMT Received: from b03cxnp07029.gho.boulder.ibm.com (b03cxnp07029.gho.boulder.ibm.com [9.17.130.16]) by ppma01wdc.us.ibm.com with ESMTP id 3f6tyswbdb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 08 Apr 2022 22:32:47 +0000 Received: from b03ledav005.gho.boulder.ibm.com (b03ledav005.gho.boulder.ibm.com [9.17.130.236]) by b03cxnp07029.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 238MWlpH25559430 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 8 Apr 2022 22:32:47 GMT Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 312B4BE06F; Fri, 8 Apr 2022 22:32:47 +0000 (GMT) Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C133CBE051; Fri, 8 Apr 2022 22:32:46 +0000 (GMT) Received: from linux.ibm.com (unknown [9.65.88.206]) by b03ledav005.gho.boulder.ibm.com (Postfix) with ESMTP; Fri, 8 Apr 2022 22:32:46 +0000 (GMT) From: Tulio Magno Quites Machado Filho To: libc-alpha@sourceware.org Cc: Alan Modra Subject: Re: [PATCH v2 3/4] powerpc: Relocate stinfo->main In-Reply-To: <20220228064052.3413334-4-amodra@gmail.com> References: <20220228064052.3413334-1-amodra@gmail.com> <20220228064052.3413334-4-amodra@gmail.com> User-Agent: Notmuch/0.35 (http://notmuchmail.org) Emacs/27.2 (x86_64-redhat-linux-gnu) Date: Fri, 08 Apr 2022 19:32:45 -0300 Message-ID: <87zgkv1a0i.fsf@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-GUID: qTH2bQbDn0Cnp5uPiw1tkeQma50kfWQb X-Proofpoint-ORIG-GUID: kWCqFcBxUSsFUT1KUgkO4BP53vNGJQDv X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.425,FMLib:17.11.64.514 definitions=2022-04-08_08,2022-04-08_01,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 spamscore=0 impostorscore=0 lowpriorityscore=0 suspectscore=0 malwarescore=0 priorityscore=1501 adultscore=0 bulkscore=0 clxscore=1015 mlxscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2204080115 X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Apr 2022 22:33:18 -0000 Alan Modra via Libc-alpha writes: > diff --git a/sysdeps/unix/sysv/linux/powerpc/libc-start.c b/sysdeps/unix/= sysv/linux/powerpc/libc-start.c > index bb97d16145..8f0d3a0eac 100644 > --- a/sysdeps/unix/sysv/linux/powerpc/libc-start.c > +++ b/sysdeps/unix/sysv/linux/powerpc/libc-start.c > @@ -23,6 +23,10 @@ > #ifndef SHARED > #include > #endif > +#if ENABLE_STATIC_PIE && !defined SHARED > +/* For elf_machine_load_address. */ > +#include > +#endif >=20=20 > /* The main work is done in the generic function. */ > #define LIBC_START_MAIN generic_start_main > @@ -95,8 +99,15 @@ __libc_start_main_impl (int argc, char **argv, > __tcb_parse_hwcap_and_convert_at_platform (); > #endif >=20=20 > - return generic_start_main (stinfo->main, argc, argv, auxvec, > - stinfo->init, stinfo->fini, rtld_fini, > + void *main =3D stinfo->main; Some GCC versions (e.g. GCC 8) complain about the name of this variable: ../sysdeps/unix/sysv/linux/powerpc/libc-start.c: In function =E2=80=98__lib= c_start_main_impl=E2=80=99: ../sysdeps/unix/sysv/linux/powerpc/libc-start.c:102:9: error: =E2=80=98main= =E2=80=99 is usually a function [-Werror=3Dmain] Looks good to me if this variable is either renamed or if this part of the = code is built with -Wno-main. Reviewed-by: Tulio Magno Quites Machado Filho --=20 Tulio Magno