From: Florian Weimer <fweimer@redhat.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: "Adhemerval Zanella via Libc-alpha" <libc-alpha@sourceware.org>,
"Fāng-ruì Sòng" <maskray@google.com>
Subject: Re: [PATCH] Remove fno-unit-at-a-time make variable
Date: Tue, 05 Apr 2022 22:26:25 +0200 [thread overview]
Message-ID: <87zgkzuvim.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <06ae38bd-cccb-9f00-b23a-5a1232a26763@linaro.org> (Adhemerval Zanella's message of "Tue, 5 Apr 2022 17:01:47 -0300")
* Adhemerval Zanella:
> On 05/04/2022 14:53, Florian Weimer wrote:
>> * Adhemerval Zanella via Libc-alpha:
>>
>>> This is not what I am seeing on my clang branch, where clang with integrated
>>> moves the global asm directives to the top of the file. And it makes
>>> check-abi fail due the _sys_errlist/sys_errlist being with wrong value.
>>
>> You can move the directives to the bottom of the file by creating a
>> temporary .s file and #include that from a wrapper .S file that
>> #includes the .s file.
>
> Not sure I am following your suggestion here, do you mean get the -S
> output file from compiler?
Yes, H.J. did that in earlier patches. But I didn't like it back then. 8-p
> Making an assembly file is really tricky here because _sys_errlist_internal
> contains internal gap (the errno values are not strictly sequential). The
> compiler handles by adding '.zero' commands, which is not easily. I think
> we might generate it though a script.
I think the input file is already generated by a script.
Thanks,
Florian
next prev parent reply other threads:[~2022-04-05 20:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-30 5:07 Fangrui Song
2022-03-30 12:46 ` Adhemerval Zanella
2022-03-30 16:23 ` Fangrui Song
2022-03-30 16:28 ` Adhemerval Zanella
2022-03-31 3:43 ` Fangrui Song
2022-03-31 11:33 ` Adhemerval Zanella
2022-04-04 15:57 ` Fangrui Song
2022-04-05 14:35 ` Adhemerval Zanella
2022-04-05 16:22 ` Fāng-ruì Sòng
2022-04-05 16:40 ` Adhemerval Zanella
2022-04-05 16:44 ` Fāng-ruì Sòng
2022-04-05 16:49 ` Adhemerval Zanella
2022-04-05 17:53 ` Florian Weimer
2022-04-05 20:01 ` Adhemerval Zanella
2022-04-05 20:26 ` Florian Weimer [this message]
2022-04-05 20:30 ` Adhemerval Zanella
2022-04-05 20:40 ` Florian Weimer
2022-04-05 21:15 ` Adhemerval Zanella
2022-04-06 15:35 ` Adhemerval Zanella
2022-04-07 7:02 ` Fāng-ruì Sòng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgkzuvim.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
--cc=maskray@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).