From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bat.birch.relay.mailchannels.net (bat.birch.relay.mailchannels.net [23.83.209.13]) by sourceware.org (Postfix) with ESMTPS id 4CA503858D28 for ; Wed, 9 Feb 2022 13:57:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4CA503858D28 X-Sender-Id: dreamhost|x-authsender|tuliom@ascii.art.br Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 538EF621CD1; Wed, 9 Feb 2022 13:57:29 +0000 (UTC) Received: from pdx1-sub0-mail-a299.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id BB90062187C; Wed, 9 Feb 2022 13:57:28 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|tuliom@ascii.art.br Received: from pdx1-sub0-mail-a299.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.106.113.27 (trex/6.4.3); Wed, 09 Feb 2022 13:57:29 +0000 X-MC-Relay: Junk X-MailChannels-SenderId: dreamhost|x-authsender|tuliom@ascii.art.br X-MailChannels-Auth-Id: dreamhost X-Obese-Whimsical: 6b83e07004209491_1644415049003_887018611 X-MC-Loop-Signature: 1644415049003:1548083656 X-MC-Ingress-Time: 1644415049003 Received: from ascii.art.br (ip-191-5-87-111.isp.valenet.com.br [191.5.87.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: tuliom@ascii.art.br) by pdx1-sub0-mail-a299.dreamhost.com (Postfix) with ESMTPSA id 4Jv1fJ0ppkz2g; Wed, 9 Feb 2022 05:57:27 -0800 (PST) From: Tulio Magno Quites Machado Filho To: Noah Goldstein , libc-alpha@sourceware.org Subject: Re: [PATCH v3] String: Ensure 'MIN_PAGE_SIZE' is multiple of 'getpagesize' In-Reply-To: <20220208212459.3526397-1-goldstein.w.n@gmail.com> References: <20220207201624.601598-1-goldstein.w.n@gmail.com> <20220208212459.3526397-1-goldstein.w.n@gmail.com> User-Agent: Notmuch/0.34.1 (http://notmuchmail.org) Emacs/27.2 (x86_64-redhat-linux-gnu) Date: Wed, 09 Feb 2022 10:57:24 -0300 Message-ID: <87zgn0ta63.fsf@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-8.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Feb 2022 13:57:35 -0000 Noah Goldstein via Libc-alpha writes: > When 'TEST_LEN' was defined as (4096 * 3) the allocation size Would > not be a multiple of system page size if system page size > 4096. > --- > string/test-strcmp.c | 14 +++++++------- > string/test-strncmp.c | 18 +++++++++--------- > 2 files changed, 16 insertions(+), 16 deletions(-) > > diff --git a/string/test-strcmp.c b/string/test-strcmp.c > index eacbdc8857..0abce769d0 100644 > --- a/string/test-strcmp.c > +++ b/string/test-strcmp.c > @@ -16,7 +16,7 @@ > License along with the GNU C Library; if not, see > . */ > > -#define TEST_LEN (4096 * 3) > +#define TEST_LEN (getpagesize () * 3) > #define MIN_PAGE_SIZE (TEST_LEN + 2 * getpagesize ()) > > #define TEST_MAIN > @@ -393,7 +393,7 @@ int > test_main (void) > { > size_t i, j; > - > + const size_t test_len = MIN(TEST_LEN, 3 * 4096); I didn't understand this part. Is the intention here to protect against platforms with a page size less than 4096? -- Tulio Magno