From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <fweimer@redhat.com>
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by sourceware.org (Postfix) with ESMTPS id D81E93858C83
 for <libc-alpha@sourceware.org>; Tue,  1 Feb 2022 18:14:21 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D81E93858C83
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-10-POoJB32ONaeGfgnlhIQRCw-1; Tue, 01 Feb 2022 13:14:18 -0500
X-MC-Unique: POoJB32ONaeGfgnlhIQRCw-1
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com
 [10.5.11.13])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1F07E814245;
 Tue,  1 Feb 2022 18:14:17 +0000 (UTC)
Received: from oldenburg.str.redhat.com (unknown [10.39.193.205])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id D8E9484A39;
 Tue,  1 Feb 2022 18:14:15 +0000 (UTC)
From: Florian Weimer <fweimer@redhat.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: libc-alpha@sourceware.org,  Carlos O'Donell <carlos@redhat.com>,  "H . J
 . Lu" <hjl.tools@gmail.com>
Subject: Re: [PATCH v2] posix: Replace posix_spawnattr_tc{get,set}pgrp_np
 with posix_spawn_file_actions_addtcsetpgrp_np
References: <20220129200620.501423-1-adhemerval.zanella@linaro.org>
Date: Tue, 01 Feb 2022 19:14:14 +0100
In-Reply-To: <20220129200620.501423-1-adhemerval.zanella@linaro.org>
 (Adhemerval Zanella's message of "Sat, 29 Jan 2022 17:06:20 -0300")
Message-ID: <87zgna1mkp.fsf@oldenburg.str.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain
X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW,
 SPF_HELO_NONE, SPF_NONE, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 01 Feb 2022 18:14:23 -0000

* Adhemerval Zanella:

> @@ -235,6 +220,13 @@ posix_spawn_file_actions_addclosefrom_np (posix_spawn_file_actions_t *,
>  					  int __from)
>       __THROW __nonnull ((1));
>  
> +/* Add an action fo set the terminal foregroup process group on the terminal

Typo: foregrou[nd]

The API addition looks okay to me.

I've also checked that this patch passes build-many-glibcs.py.

Thanks,
Florian