From: Florian Weimer <fw@deneb.enyo.de>
To: Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH 1/7] support: Add xmkfifo
Date: Tue, 05 Oct 2021 21:10:54 +0200 [thread overview]
Message-ID: <87zgrn1e4h.fsf@mid.deneb.enyo.de> (raw)
In-Reply-To: <20211005135631.3209020-2-adhemerval.zanella@linaro.org> (Adhemerval Zanella via Libc-alpha's message of "Tue, 5 Oct 2021 10:56:25 -0300")
* Adhemerval Zanella via Libc-alpha:
> diff --git a/support/xmkfifo.c b/support/xmkfifo.c
> new file mode 100644
> index 0000000000..d9f3e9fde7
> --- /dev/null
> +++ b/support/xmkfifo.c
> +void
> +xmkfifo (const char *pathname, mode_t mode)
> +{
> + int r = mkfifo (pathname, mode);
> + if (r < 0)
> + FAIL_EXIT1 ("mkfifo (%s, %d): %m", pathname, mode);
> +}
Please use 0%o for the mode, I think it's more customary.
> diff --git a/support/xunistd.h b/support/xunistd.h
> index e4ade65c85..d2f66c7873 100644
> --- a/support/xunistd.h
> +++ b/support/xunistd.h
> @@ -61,6 +61,7 @@ void xsymlink (const char *target, const char *linkpath);
> void xchdir (const char *path);
> void xfchmod (int fd, mode_t mode);
> void xchmod (const char *pathname, mode_t mode);
> +void xmkfifo (const char *pathtname, mode_t mode);
Typo: path[]name
next prev parent reply other threads:[~2021-10-05 19:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-05 13:56 [PATCH 0/7] Use RFC5424 for syslog Adhemerval Zanella
2021-10-05 13:56 ` [PATCH 1/7] support: Add xmkfifo Adhemerval Zanella
2021-10-05 19:10 ` Florian Weimer [this message]
2021-10-06 19:25 ` Adhemerval Zanella
2021-10-05 13:56 ` [PATCH 2/7] misc: Add syslog test Adhemerval Zanella
2021-10-05 13:56 ` [PATCH 3/7] misc: syslog: Fix indentation and style Adhemerval Zanella
2021-10-05 13:56 ` [PATCH 4/7] misc: syslog: Simplify implementation Adhemerval Zanella
2021-10-05 13:56 ` [PATCH 5/7] misc: syslog: Use static buffer Adhemerval Zanella
2021-10-05 13:56 ` [PATCH 6/7] misc: syslog: Move SYSLOG_NAME to USE_MISC (BZ #16355) Adhemerval Zanella
2021-10-05 13:56 ` [PATCH 7/7] misc: syslog: Use RFC5424 Adhemerval Zanella
2021-10-05 19:07 ` Paul Eggert
2021-10-06 19:36 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgrn1e4h.fsf@mid.deneb.enyo.de \
--to=fw@deneb.enyo.de \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).