From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <fweimer@redhat.com>
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by sourceware.org (Postfix) with ESMTP id 3D07F383B425
 for <libc-alpha@sourceware.org>; Tue,  1 Jun 2021 07:51:28 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3D07F383B425
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-18-7cYqDDqnPUecUwvQfJjX7g-1; Tue, 01 Jun 2021 03:51:26 -0400
X-MC-Unique: 7cYqDDqnPUecUwvQfJjX7g-1
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com
 [10.5.11.13])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0F8EA80574B;
 Tue,  1 Jun 2021 07:51:24 +0000 (UTC)
Received: from oldenburg.str.redhat.com (ovpn-113-228.ams2.redhat.com
 [10.36.113.228])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id 3EC4660CCE;
 Tue,  1 Jun 2021 07:51:22 +0000 (UTC)
From: Florian Weimer <fweimer@redhat.com>
To: Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH v2 1/9] nptl: Remove exit-thread.h
References: <20210527172823.3461314-1-adhemerval.zanella@linaro.org>
 <20210527172823.3461314-2-adhemerval.zanella@linaro.org>
Date: Tue, 01 Jun 2021 09:51:21 +0200
In-Reply-To: <20210527172823.3461314-2-adhemerval.zanella@linaro.org>
 (Adhemerval Zanella via Libc-alpha's message of "Thu, 27 May 2021
 14:28:15 -0300")
Message-ID: <87zgwa6n0m.fsf@oldenburg.str.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain
X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0,
 RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,
 SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 01 Jun 2021 07:51:30 -0000

* Adhemerval Zanella via Libc-alpha:

> diff --git a/nptl/pthread_create.c b/nptl/pthread_create.c
> index 2d2535b07d..aacbba1cac 100644
> --- a/nptl/pthread_create.c
> +++ b/nptl/pthread_create.c
> @@ -30,7 +30,6 @@
>  #include <libc-internal.h>
>  #include <resolv.h>
>  #include <kernel-features.h>
> -#include <exit-thread.h>
>  #include <default-sched.h>
>  #include <futex-internal.h>
>  #include <tls-setup.h>
> @@ -575,7 +574,10 @@ start_thread (void *arg)
>  
>       The exit code is zero since in case all threads exit by calling
>       'pthread_exit' the exit status must be 0 (zero).  */
> -  __exit_thread ();
> +  while (1)
> +    {
> +      INTERNAL_SYSCALL_CALL (exit, 0);
> +    }
>  
>    /* NOTREACHED */
>  }

You could leave off the braces.  But still looks good.

Thanks,
Florian