public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: Lirong Yuan via Libc-alpha <libc-alpha@sourceware.org>
Cc: Lirong Yuan <yuanzi@google.com>,  schwab@linux-m68k.org,  scw@google.com
Subject: Re: [PATCH v3] locale: align _nl_C_LC_CTYPE_class and _nl_C_LC_CTYPE_class32 arrays to uint16_t and uint32_t respectively
Date: Mon, 03 May 2021 16:33:32 +0200	[thread overview]
Message-ID: <87zgxbzy2r.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20210401193723.1224640-1-yuanzi@google.com> (Lirong Yuan via Libc-alpha's message of "Thu, 1 Apr 2021 12:37:23 -0700")

* Lirong Yuan via Libc-alpha:

> steps to reproduce the problem: compile a program that uses ctype functions such as “isspace” for aarch64 with UBSan flag “-fsanitize=undefined” and run it on x86_64 machines with qemu user mode emulation.
>
> observed behavior: UndefinedBehaviorSanitizer reports misaligned-pointer-use in the program.
>
> solution: align the arrays defined in locale/C-ctype.c with correct data types as defined in ctype/ctype.h.
>
> test suite regressions: none.

I've pushed this patch for you with a reworded commit message and minor
formatting changes.  Thanks.

Florian


  reply	other threads:[~2021-05-03 14:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-01 19:37 Lirong Yuan
2021-05-03 14:33 ` Florian Weimer [this message]
2021-05-03 15:08   ` Lirong Yuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zgxbzy2r.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    --cc=schwab@linux-m68k.org \
    --cc=scw@google.com \
    --cc=yuanzi@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).