From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id AABB8393BC3B for ; Mon, 3 May 2021 14:33:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org AABB8393BC3B Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-26-eVHyFfVQMgWo3pK8XnvNQw-1; Mon, 03 May 2021 10:33:21 -0400 X-MC-Unique: eVHyFfVQMgWo3pK8XnvNQw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A5DC08015BA; Mon, 3 May 2021 14:33:20 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-112-137.ams2.redhat.com [10.36.112.137]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7248510027C4; Mon, 3 May 2021 14:33:19 +0000 (UTC) From: Florian Weimer To: Lirong Yuan via Libc-alpha Cc: Lirong Yuan , schwab@linux-m68k.org, scw@google.com Subject: Re: [PATCH v3] locale: align _nl_C_LC_CTYPE_class and _nl_C_LC_CTYPE_class32 arrays to uint16_t and uint32_t respectively References: <20210401193723.1224640-1-yuanzi@google.com> Date: Mon, 03 May 2021 16:33:32 +0200 In-Reply-To: <20210401193723.1224640-1-yuanzi@google.com> (Lirong Yuan via Libc-alpha's message of "Thu, 1 Apr 2021 12:37:23 -0700") Message-ID: <87zgxbzy2r.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 May 2021 14:33:24 -0000 * Lirong Yuan via Libc-alpha: > steps to reproduce the problem: compile a program that uses ctype functio= ns such as =E2=80=9Cisspace=E2=80=9D for aarch64 with UBSan flag =E2=80=9C-= fsanitize=3Dundefined=E2=80=9D and run it on x86_64 machines with qemu user= mode emulation. > > observed behavior: UndefinedBehaviorSanitizer reports misaligned-pointer-= use in the program. > > solution: align the arrays defined in locale/C-ctype.c with correct data = types as defined in ctype/ctype.h. > > test suite regressions: none. I've pushed this patch for you with a reworded commit message and minor formatting changes. Thanks. Florian