From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id 87E79386EC2F for ; Tue, 6 Apr 2021 18:41:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 87E79386EC2F Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-530-iD5qXdthOfGiHKn6GhdlUw-1; Tue, 06 Apr 2021 14:41:29 -0400 X-MC-Unique: iD5qXdthOfGiHKn6GhdlUw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D24A8180FCA3; Tue, 6 Apr 2021 18:41:28 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-112-12.rdu2.redhat.com [10.10.112.12]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A784F60937; Tue, 6 Apr 2021 18:41:27 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Subject: Re: [PATCH v3 36/37] nptl: Move setxid broadcast implementation into libc References: <67a2fc1add8e478af071fc21b37c175e671e8f03.1615914632.git.fweimer@redhat.com> <7f8f38af-ed62-b7fb-aa88-590a3c9916a6@linaro.org> Date: Tue, 06 Apr 2021 20:41:39 +0200 In-Reply-To: <7f8f38af-ed62-b7fb-aa88-590a3c9916a6@linaro.org> (Adhemerval Zanella's message of "Fri, 26 Mar 2021 15:15:37 -0300") Message-ID: <87zgybl0gs.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Apr 2021 18:41:32 -0000 * Adhemerval Zanella: >> +/* Copyright (C) 2002-2021 Free Software Foundation, Inc. >> + This file is part of the GNU C Library. >> + Contributed by Ulrich Drepper , 2002. > > Remove the 'Contributed by' Line. I prefer not to. It's a copy of an existing file. And in Germany, authors have an inalienable right to be named. >> +static struct xid_command *__xidcmd; > > No need double underscore for static variables. Okay, I've also made some of the functions static. Thanks, Florian