public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: Florian Weimer via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH] fixed typo
Date: Mon, 01 Feb 2021 15:22:19 +0100	[thread overview]
Message-ID: <87zh0nq350.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <87v9bcqcxq.fsf@oldenburg.str.redhat.com> (Florian Weimer via Libc-alpha's message of "Mon, 01 Feb 2021 11:50:41 +0100")

* Florian Weimer via Libc-alpha:

> * Paul Zimmermann:
>
>> this is the only occurrence of "NULL character" in glibc, in other places it is
>> written "NUL character".
>> Paul
>> ---
>>  sunrpc/xdr.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/sunrpc/xdr.c b/sunrpc/xdr.c
>> index b5fb7455e2..a76094d6da 100644
>> --- a/sunrpc/xdr.c
>> +++ b/sunrpc/xdr.c
>> @@ -728,7 +728,7 @@ libc_hidden_nolink_sunrpc (xdr_union, GLIBC_2_0)
>>  /*
>>   * XDR null terminated ASCII strings
>>   * xdr_string deals with "C strings" - arrays of bytes that are
>> - * terminated by a NULL character.  The parameter cpp references a
>> + * terminated by a NUL character.  The parameter cpp references a
>>   * pointer to storage; If the pointer is null, then the necessary
>>   * storage is allocated.  The last parameter is the max allowed length
>>   * of the string as specified by a protocol.
>
> Looks okay to me once glibc 2.34 opens.

And please change the commit subject before pushing this.

Thanks,
Florian
-- 
Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn,
Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill


      reply	other threads:[~2021-02-01 14:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-01 10:49 Paul Zimmermann
2021-02-01 10:50 ` Florian Weimer
2021-02-01 14:22   ` Florian Weimer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zh0nq350.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).