From: Florian Weimer <fweimer@redhat.com>
To: Matt Turner via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH] alpha: Remove anonymous union in struct stat [BZ #27042]
Date: Wed, 09 Dec 2020 18:11:52 +0100 [thread overview]
Message-ID: <87zh2m6h0n.fsf@oldenburg2.str.redhat.com> (raw)
In-Reply-To: <20201209162008.2064091-1-mattst88@gmail.com> (Matt Turner via Libc-alpha's message of "Wed, 9 Dec 2020 11:20:08 -0500")
* Matt Turner via Libc-alpha:
> This is clever, but it confuses downstream detection in at least zstd
> and GNOME's glib. zstd has preprocessor tests for the 'st_mtime' macro,
> which is not provided by the path using the anonymous union; glib checks
> for the presence of 'st_mtimensec' in struct stat but then tries to
> access that field in struct statx (which might be a bug on its own).
A more conservative approach would be adding
#define st_atime st_atime
#define st_ctime st_ctime
#define st_mtime st_mtime
to the anonymous union case.
Thanks,
Florian
--
Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn,
Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill
next prev parent reply other threads:[~2020-12-09 17:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-09 16:20 Matt Turner
2020-12-09 17:11 ` Florian Weimer [this message]
2020-12-10 1:25 ` Matt Turner
2020-12-10 1:19 ` [PATCHv2] " Matt Turner
2020-12-10 21:18 ` Adhemerval Zanella
2020-12-15 16:43 ` Matt Turner
2020-12-15 16:48 ` Adhemerval Zanella
2020-12-15 16:56 ` Florian Weimer
2020-12-17 18:18 ` Matt Turner
2020-12-17 19:10 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zh2m6h0n.fsf@oldenburg2.str.redhat.com \
--to=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).