Re: [RFC PATCH glibc 1/3] glibc: Perform rseq(2) registration at C startup and thread creation (v18)

[Florian Weimer <fweimer@redhat.com>]

* Mathieu Desnoyers:

> ----- On Apr 30, 2020, at 1:07 PM, Florian Weimer fweimer@redhat.com wrote:
> [...]
>> __libc_fatal does not attribute the error to glibc, so I suggest to
>> start the error messages with “glibc fatal error: ”, so that people know
>> where to look.
>
> OK. Is there a strict requirement on limiting to 80 columns for code
> including an error message string in glibc ? IOW:
>
>   if (__rseq_abi.cpu_id != RSEQ_CPU_ID_UNINITIALIZED)
>     __libc_fatal ("glibc fatal error: rseq already initialized for this thread\n");
>
> or
>
>   if (__rseq_abi.cpu_id != RSEQ_CPU_ID_UNINITIALIZED)
>     __libc_fatal ("glibc fatal error: "
>                   "rseq already initialized for this thread\n");
>
> ?

The latter, please.  Some code also uses

  if (__rseq_abi.cpu_id != RSEQ_CPU_ID_UNINITIALIZED)
     __libc_fatal ("\
glibc fatal error: rseq already initialized for this thread\n");

But that's not really my preference.

(Trimmed the Cc: list a bit, we are really down to glibc specifics at
this point.)

Thanks,
Florian