From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by sourceware.org (Postfix) with ESMTP id 908893898517 for ; Thu, 30 Apr 2020 17:46:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 908893898517 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-47-dacCKcndM1S2wHPnE3ZUzg-1; Thu, 30 Apr 2020 13:46:37 -0400 X-MC-Unique: dacCKcndM1S2wHPnE3ZUzg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 48AEC835B40; Thu, 30 Apr 2020 17:46:36 +0000 (UTC) Received: from oldenburg2.str.redhat.com (ovpn-113-72.ams2.redhat.com [10.36.113.72]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3BA452855B; Thu, 30 Apr 2020 17:46:32 +0000 (UTC) From: Florian Weimer To: Mathieu Desnoyers Cc: carlos , Joseph Myers , Szabolcs Nagy , libc-alpha Subject: Re: [RFC PATCH glibc 1/3] glibc: Perform rseq(2) registration at C startup and thread creation (v18) References: <20200428171513.22926-1-mathieu.desnoyers@efficios.com> <875zdhmaft.fsf@oldenburg2.str.redhat.com> <1287616647.77866.1588263099045.JavaMail.zimbra@efficios.com> <878sidkk0z.fsf@oldenburg2.str.redhat.com> <1972833271.77975.1588265754974.JavaMail.zimbra@efficios.com> <874kt0lx6i.fsf@oldenburg2.str.redhat.com> <729499446.78182.1588267203324.JavaMail.zimbra@efficios.com> Date: Thu, 30 Apr 2020 19:46:30 +0200 In-Reply-To: <729499446.78182.1588267203324.JavaMail.zimbra@efficios.com> (Mathieu Desnoyers's message of "Thu, 30 Apr 2020 13:20:03 -0400 (EDT)") Message-ID: <87zhaskgsp.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_2, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Apr 2020 17:46:40 -0000 * Mathieu Desnoyers: > ----- On Apr 30, 2020, at 1:07 PM, Florian Weimer fweimer@redhat.com wrot= e: > [...] >> __libc_fatal does not attribute the error to glibc, so I suggest to >> start the error messages with =E2=80=9Cglibc fatal error: =E2=80=9D, so = that people know >> where to look. > > OK. Is there a strict requirement on limiting to 80 columns for code > including an error message string in glibc ? IOW: > > if (__rseq_abi.cpu_id !=3D RSEQ_CPU_ID_UNINITIALIZED) > __libc_fatal ("glibc fatal error: rseq already initialized for this t= hread\n"); > > or > > if (__rseq_abi.cpu_id !=3D RSEQ_CPU_ID_UNINITIALIZED) > __libc_fatal ("glibc fatal error: " > "rseq already initialized for this thread\n"); > > ? The latter, please. Some code also uses if (__rseq_abi.cpu_id !=3D RSEQ_CPU_ID_UNINITIALIZED) __libc_fatal ("\ glibc fatal error: rseq already initialized for this thread\n"); But that's not really my preference. (Trimmed the Cc: list a bit, we are really down to glibc specifics at this point.) Thanks, Florian