From: Tulio Magno Quites Machado Filho <tuliom@ascii.art.br>
To: "Paul E. Murphy" <murphyp@linux.vnet.ibm.com>, libc-alpha@sourceware.org
Subject: Re: [PATCH 5/7] ldbl-128ibm-compat: enforce ibm128 on compat tests
Date: Thu, 27 Feb 2020 20:39:00 -0000 [thread overview]
Message-ID: <87zhd3u5n7.fsf@linux.ibm.com> (raw)
In-Reply-To: <20200214161051.32579-6-murphyp@linux.vnet.ibm.com>
"Paul E. Murphy" <murphyp@linux.vnet.ibm.com> writes:
> For lack of a more comprehensive solution, tack on the ibm128 ABI
> compiler options for the totalorder{,mag}l compat tests which exist
> prior to enabling this feature.
> ---
> sysdeps/ieee754/ldbl-128ibm-compat/Makefile | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/sysdeps/ieee754/ldbl-128ibm-compat/Makefile b/sysdeps/ieee754/ldbl-128ibm-compat/Makefile
> index e40ae08469..af8027cf0e 100644
> --- a/sysdeps/ieee754/ldbl-128ibm-compat/Makefile
> +++ b/sysdeps/ieee754/ldbl-128ibm-compat/Makefile
> @@ -270,6 +270,7 @@ tests-internal += tst-ibm128-error tst-ieee128-error
> tests-internal += tst-ibm128-efgcvt tst-ieee128-efgcvt
>
> $(objpfx)tst-ieee128-efgcvt: gnulib-tests += $(f128-loader-link)
> +$(objpfx)tst-ldbl-efgcvt: gnulib-tests += $(f128-loader-link)
LGTM, but I think this test should mentioned in the commit message too.
Reviewed-by: Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>
--
Tulio Magno
next prev parent reply other threads:[~2020-02-27 20:39 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 16:10 [PATCH 0/7] Remaining ldbl-128ibm-compat support Paul E. Murphy
2020-02-14 16:11 ` [PATCH 3/7] ldbl-128ibm-compat: Add tests for IBM long double functions Paul E. Murphy
2020-02-14 17:31 ` Joseph Myers
2020-02-14 18:22 ` Paul E Murphy
2020-02-14 21:14 ` Joseph Myers
2020-02-17 22:06 ` [PATCHv2 " Paul E. Murphy
2020-02-17 22:25 ` Joseph Myers
2020-02-18 22:01 ` [PATCHv3] " Paul E. Murphy
2020-02-28 15:33 ` [PATCHv3][Ping] " Paul E Murphy
2020-03-03 20:17 ` Paul E Murphy
2020-03-06 19:37 ` Paul E Murphy
2020-02-14 16:11 ` [PATCH 7/7] RFC: ldbl-128ibm-compat: PLT redirects for using ldbl redirects internally Paul E. Murphy
2020-02-27 20:58 ` Tulio Magno Quites Machado Filho
2020-02-28 17:21 ` Paul E Murphy
2020-02-14 16:11 ` [PATCH 2/7] ldbl-128ibm-compat: enforce correct abi flags on internal file Paul E. Murphy
2020-02-21 14:35 ` Paul E Murphy
2020-02-14 16:11 ` [PATCH 5/7] ldbl-128ibm-compat: enforce ibm128 on compat tests Paul E. Murphy
2020-02-27 20:39 ` Tulio Magno Quites Machado Filho [this message]
2020-02-27 22:45 ` Paul E Murphy
2020-02-28 14:57 ` Paul E Murphy
2020-02-14 16:11 ` [PATCH 1/7] ldbl-128ibm-compat: Provide nexttoward functions Paul E. Murphy
2020-02-27 20:17 ` Tulio Magno Quites Machado Filho
2020-02-28 14:56 ` Paul E Murphy
2020-02-14 16:11 ` [PATCH 4/7] ldbl-128ibm-compat: fixup subdir location of several funcs Paul E. Murphy
2020-02-21 14:34 ` Paul E Murphy
2020-02-14 16:11 ` [PATCH 6/7] ldbl-128ibm: Let long double files have specific compiler flags Paul E. Murphy
2020-03-03 20:18 ` Paul E Murphy
2020-03-06 19:38 ` Paul E Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhd3u5n7.fsf@linux.ibm.com \
--to=tuliom@ascii.art.br \
--cc=libc-alpha@sourceware.org \
--cc=murphyp@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).