From: Tulio Magno Quites Machado Filho <tuliom@ascii.art.br>
To: GT <tnggil@protonmail.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH v0] PPC64: Attach SIMD attribute to cosf, sin, sinf function declarations.
Date: Thu, 13 Feb 2020 20:19:00 -0000 [thread overview]
Message-ID: <87zhdms0jr.fsf@linux.ibm.com> (raw)
In-Reply-To: <y3k845Zx_Nv75DVXPhcJ1loMnGNoXUtATjMouy6MVdKQ8XcuUz17_e_tR5XzRZqPmLqEMMqqJzPnaGVtf0X4-2a2dNTuwVpnWq4tIYNnSyE=@protonmail.com>
GT <tnggil@protonmail.com> writes:
> On Thursday, February 13, 2020 2:26 PM, Tulio Magno Quites Machado Filho <tuliom@ascii.art.br> wrote:
>
> The commits whose abbreviated ids are c1782a410f, 1bd6ae3a5a, and 29d3adfe09.
> Each of them introduces a test to ensure that feature(s) used in immediately preceding
> patches are available on the system.
OK.
> My understanding is that by using git rebase, each of those 3 commits can be combined
> with the earlier patch that should have had the feature tests initially. I am assuming that
> it is ok to re-write history in branch tuliom/libmvec in this manner. If not so, then you
> may dismiss the suggestion.
I don't think these changes are necessary.
> I wanted to use the same order of defines/undefines as the math-vector.h for x86-64 at:
> sysdeps/x86/fpu/bits/
I also don't think these files need to be identical.
The patch LGTM if it adds the missing declarations.
--
Tulio Magno
next prev parent reply other threads:[~2020-02-13 20:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 18:43 GT
2020-02-13 19:27 ` Tulio Magno Quites Machado Filho
2020-02-13 19:56 ` GT
2020-02-13 20:19 ` Tulio Magno Quites Machado Filho [this message]
2020-02-13 21:00 ` GT
2020-02-19 18:32 ` Tulio Magno Quites Machado Filho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhdms0jr.fsf@linux.ibm.com \
--to=tuliom@ascii.art.br \
--cc=libc-alpha@sourceware.org \
--cc=tnggil@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).