From: Florian Weimer <fw@deneb.enyo.de>
To: Joseph Myers <joseph@codesourcery.com>
Cc: <libc-alpha@sourceware.org>
Subject: Re: Update SOMAXCONN value from Linux 5.4
Date: Fri, 29 Nov 2019 08:35:00 -0000 [thread overview]
Message-ID: <87zhgf9j2g.fsf@mid.deneb.enyo.de> (raw)
In-Reply-To: <874kynaxro.fsf@mid.deneb.enyo.de> (Florian Weimer's message of "Fri, 29 Nov 2019 09:32:11 +0100")
* Florian Weimer:
> * Joseph Myers:
>
>> Linux 5.4 changes the SOMAXCONN value from 128 to 4096 (this isn't in
>> a uapi header; various constants related to the kernel/userspace
>> interface, including this one, are in the non-uapi linux/socket.h
>> header).
>>
>> This patch increases the value in glibc. As I understand it, it is
>> safe to use a higher value even with older kernels (the kernel will
>> simply adjust the value passed to listen to be no more than the value
>> supported in the kernel), and SOMAXCONN is actually only a default for
>> a sysctl value in the kernel that can be changed at runtime. So I
>> think updating the value in glibc is a reasonable and safe thing to
>> do.
>
> Should we add a deprecation warning to the macro and eventually remove
> it, given that it's not actually a constant?
Oh, I see: POSIX assumes that the implementation uses a constant value
for the queue length and requires us to define the macro.
prev parent reply other threads:[~2019-11-29 8:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-29 1:10 Joseph Myers
2019-11-29 4:18 ` Carlos O'Donell
2019-11-29 8:32 ` Florian Weimer
2019-11-29 8:35 ` Florian Weimer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhgf9j2g.fsf@mid.deneb.enyo.de \
--to=fw@deneb.enyo.de \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).