From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-106017-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 82169 invoked by alias); 16 Oct 2019 10:34:50 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 82160 invoked by uid 89); 16 Oct 2019 10:34:50 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-6.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=Schwab
X-HELO: mx1.redhat.com
From: Florian Weimer <fweimer@redhat.com>
To: Andreas Schwab <schwab@suse.de>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] ldconfig: handle .dynstr located in separate segment (bug 25087)
References: <mvmsgo1q758.fsf@suse.de>
Date: Wed, 16 Oct 2019 10:34:00 -0000
In-Reply-To: <mvmsgo1q758.fsf@suse.de> (Andreas Schwab's message of "Thu, 10
	Oct 2019 11:30:59 +0200")
Message-ID: <87zhi1567u.fsf@oldenburg2.str.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SW-Source: 2019-10/txt/msg00480.txt.bz2

* Andreas Schwab:

> +		  && dyn_entry->d_un.d_val < segment->p_vaddr + segment->p_filesz)

> +	  dynamic_strings = (char *) (file_contents + dyn_entry->d_un.d_val - loadoff);

I think these lines are too long.  I also suspect that the condition
should be written as

  dyn_entry->d_un.d_val - segment->p_vaddr < segment->p_filesz

But in principle, the change looks fine.

Is it possible to write a test case for bug 25087?

Thanks,
Florian