From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 87216 invoked by alias); 10 Jan 2019 11:01:05 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 86672 invoked by uid 89); 10 Jan 2019 11:00:43 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS autolearn=unavailable version=3.3.2 spammy=Hx-languages-length:1055 X-HELO: mx1.redhat.com From: Florian Weimer To: Andreas K. =?utf-8?Q?H=C3=BCttel?= Cc: libc-alpha@sourceware.org Subject: Re: [PATCH] resolv: AAAA (28) is valid, no fallthrough to default References: <20190110001717.25717-1-dilfridge@gentoo.org> Date: Thu, 10 Jan 2019 11:01:00 -0000 In-Reply-To: <20190110001717.25717-1-dilfridge@gentoo.org> ("Andreas K. \=\?utf-8\?Q\?H\=C3\=BCttel\=22's\?\= message of "Thu, 10 Jan 2019 01:17:17 +0100") Message-ID: <87zhs8lqvb.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2019-01/txt/msg00223.txt.bz2 * Andreas K. H=C3=BCttel: > The test resolv/tst-resolv-ai_idn-nolibidn2 kept failing, with the puzzli= ng > output "invalid qtype: 28". Puzzling since 28 is an AAAA record. > Turns out the switch statement is missing a break, so the "T_AAAA" case > continues with "default". > --- > resolv/tst-resolv-ai_idn-common.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/resolv/tst-resolv-ai_idn-common.c b/resolv/tst-resolv-ai_idn= -common.c > index bb81c2ca23..61cc81b71f 100644 > --- a/resolv/tst-resolv-ai_idn-common.c > +++ b/resolv/tst-resolv-ai_idn-common.c > @@ -241,6 +241,7 @@ response (const struct resolv_response_context *ctx, > qname[0] }; > resolv_response_add_data (b, &addr, sizeof (addr)); > } > + break; > default: > FAIL_EXIT1 ("invalid qtype: %d", qtype); > } The change is obviously correct. I will commit it for you. However, how do you encounter this issue? Did you change some test? The current IDN tests do not actually send AAAA queries, I think. Thanks, Florian