public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>
To: "Gabriel F. T. Gomes" <gabriel@inconstante.eti.br>,
	libc-alpha@sourceware.org
Subject: Re: [PATCH] powerpc64le: Fix TFtype in sqrtf128 when using -mabi=ieeelongdouble
Date: Wed, 06 Jun 2018 15:31:00 -0000	[thread overview]
Message-ID: <87zi08c4qk.fsf@linux.ibm.com> (raw)
In-Reply-To: <20180601165928.29fbf20b@tereshkova>

"Gabriel F. T. Gomes" <gabriel@inconstante.eti.br> writes:

> On Mon, 28 May 2018, Tulio Magno Quites Machado Filho wrote:
>
>>	* sysdeps/powerpc/powerpc64le/fpu/e_sqrtf128.c
>                           ~~~~~~~~~~~
> Missing the slash, i.e.: powerpc64/le.

Oops.  This was outdated.

>>--- a/sysdeps/powerpc/powerpc64/le/fpu/e_sqrtf128.c
>>+++ b/sysdeps/powerpc/powerpc64/le/fpu/e_sqrtf128.c
>>@@ -26,9 +26,12 @@
>>    License along with the GNU C Library; if not, see
>>    <http://www.gnu.org/licenses/>.  */
>> 
>>-/* Unavoidable hacks since TFmode is assumed to be binary128. */
>>-#define TFtype KFtype
>>-#define TF KF
>>+/* Unavoidable hacks since TFmode is assumed to be binary128 when
>>+   -mabi=ibmlongdouble is used.  */
>>+#if __HAVE_FLOAT128_UNLIKE_LDBL
>
> Don't you have to include bits/floatn.h to get the definition of
> __HAVE_FLOAT128_UNLIKE_LDBL?

Indeed.

Fixed and pushed as 1c09524e4d.

Thanks!

-- 
Tulio Magno

      reply	other threads:[~2018-06-06 15:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-28 21:59 Tulio Magno Quites Machado Filho
2018-06-01 19:59 ` Gabriel F. T. Gomes
2018-06-06 15:31   ` Tulio Magno Quites Machado Filho [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zi08c4qk.fsf@linux.ibm.com \
    --to=tuliom@linux.ibm.com \
    --cc=gabriel@inconstante.eti.br \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).