From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-92931-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 19555 invoked by alias); 6 Jun 2018 15:31:16 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 18493 invoked by uid 89); 6 Jun 2018 15:30:28 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-12.6 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3,KAM_SHORT,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=D*br, outdated, assumed
X-HELO: mx0a-001b2d01.pphosted.com
From: Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>
To: "Gabriel F. T. Gomes" <gabriel@inconstante.eti.br>,
        libc-alpha@sourceware.org
Cc: 
Subject: Re: [PATCH] powerpc64le: Fix TFtype in sqrtf128 when using -mabi=ieeelongdouble
In-Reply-To: <20180601165928.29fbf20b@tereshkova>
References: <20180528215849.30199-1-tuliom@linux.ibm.com> <20180601165928.29fbf20b@tereshkova>
User-Agent: Notmuch/0.25 (http://notmuchmail.org) Emacs/25.3.1 (x86_64-redhat-linux-gnu)
Date: Wed, 06 Jun 2018 15:31:00 -0000
MIME-Version: 1.0
Content-Type: text/plain
X-TM-AS-GCONF: 00
x-cbid: 18060615-0064-0000-0000-0000031723E0
X-IBM-SpamModules-Scores: 
X-IBM-SpamModules-Versions: BY=3.00009139; HX=3.00000241; KW=3.00000007;
 PH=3.00000004; SC=3.00000265; SDB=6.01043027; UDB=6.00534142; IPR=6.00822157;
 MB=3.00021491; MTD=3.00000008; XFM=3.00000015; UTC=2018-06-06 15:30:15
X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused
x-cbparentid: 18060615-0065-0000-0000-00003980C391
Message-Id: <87zi08c4qk.fsf@linux.ibm.com>
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-06-06_07:,,
 signatures=0
X-SW-Source: 2018-06/txt/msg00085.txt.bz2

"Gabriel F. T. Gomes" <gabriel@inconstante.eti.br> writes:

> On Mon, 28 May 2018, Tulio Magno Quites Machado Filho wrote:
>
>>	* sysdeps/powerpc/powerpc64le/fpu/e_sqrtf128.c
>                           ~~~~~~~~~~~
> Missing the slash, i.e.: powerpc64/le.

Oops.  This was outdated.

>>--- a/sysdeps/powerpc/powerpc64/le/fpu/e_sqrtf128.c
>>+++ b/sysdeps/powerpc/powerpc64/le/fpu/e_sqrtf128.c
>>@@ -26,9 +26,12 @@
>>    License along with the GNU C Library; if not, see
>>    <http://www.gnu.org/licenses/>.  */
>> 
>>-/* Unavoidable hacks since TFmode is assumed to be binary128. */
>>-#define TFtype KFtype
>>-#define TF KF
>>+/* Unavoidable hacks since TFmode is assumed to be binary128 when
>>+   -mabi=ibmlongdouble is used.  */
>>+#if __HAVE_FLOAT128_UNLIKE_LDBL
>
> Don't you have to include bits/floatn.h to get the definition of
> __HAVE_FLOAT128_UNLIKE_LDBL?

Indeed.

Fixed and pushed as 1c09524e4d.

Thanks!

-- 
Tulio Magno