From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 101120 invoked by alias); 5 Apr 2017 14:52:04 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 101099 invoked by uid 89); 5 Apr 2017 14:52:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 spammy= X-HELO: mx0a-001b2d01.pphosted.com From: "Tulio Magno Quites Machado Filho" To: Wainer dos Santos Moschetta , libc-alpha@sourceware.org Cc: Subject: Re: [PATCH v3] Add page tests to string/test-strnlen. In-Reply-To: <20170331203729.23812-1-wainersm@linux.vnet.ibm.com> References: <20170331203729.23812-1-wainersm@linux.vnet.ibm.com> User-Agent: Notmuch/0.20.2 (http://notmuchmail.org) Emacs/24.4.51.1 (x86_64-unknown-linux-gnu) Date: Wed, 05 Apr 2017 14:52:00 -0000 MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-MML: disable x-cbid: 17040514-0032-0000-0000-0000055200E6 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17040514-0033-0000-0000-000011D70688 Message-Id: <87zifu3o1v.fsf@totoro.br.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-04-05_11:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1704050129 X-SW-Source: 2017-04/txt/msg00078.txt.bz2 Wainer dos Santos Moschetta writes: > May be tricky for otimized implementations to handle strings around > page boundary once, for instance, it is performed unaligned loads or > when maxlen is used as a hint for vectorized loops. The test cases > should unveil regression bugs on these cases. > > To some extend do_random_tests in string/test-strnlen tests strings > placed at page end but it does not cover all cases. So this change > adds tests which consists of placing strings of varying sizes ending > at the page boundary. It also combines with different values of maxlen. > > Tested on ppc64le and x86_64. > > 2017-03-31 Wainer dos Santos Moschetta > > * string/test-strnlen.c (do_page_tests): New function > to check length of strings ending at the page boundary. > (test_main): Added call to the do_page_tests function. LGTM too. Pushed as ff65c87. -- Tulio Magno