From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32934 invoked by alias); 1 Jan 2017 13:40:32 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 32908 invoked by uid 89); 1 Jan 2017 13:40:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.8 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=interactions, Never, poses, Hx-languages-length:805 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail.esperi.org.uk From: Nix To: Florian Weimer Cc: siddhesh@sourceware.org, libc-alpha@sourceware.org, carlos@redhat.com Subject: Re: [PATCH 1/4] Add framework for tunables References: <1483198831-2232-1-git-send-email-siddhesh@sourceware.org> <1483198831-2232-2-git-send-email-siddhesh@sourceware.org> <8dff6c1a-cd60-47e0-c7c3-df73a7139f4d@redhat.com> <26463979-4563-d3eb-f65b-c8b7729178c9@sourceware.org> <5ffd4870-bb10-e99e-2c12-4cb5437e3e07@redhat.com> Date: Sun, 01 Jan 2017 13:40:00 -0000 In-Reply-To: <5ffd4870-bb10-e99e-2c12-4cb5437e3e07@redhat.com> (Florian Weimer's message of "Sat, 31 Dec 2016 20:52:26 +0100") Message-ID: <87zijakif4.fsf@esperi.org.uk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.94 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-DCC-EATSERVER-Metrics: spindle 1166; Body=4 Fuz1=4 Fuz2=4 X-SW-Source: 2017-01/txt/msg00010.txt.bz2 On 31 Dec 2016, Florian Weimer told this: > On 12/31/2016 08:49 PM, Siddhesh Poyarekar wrote: > >>> I've also realized that the suggested csu/ move >>> did not happen, so building with stack protector enabled could be broken. >> >> I saw your comment about it but did not link it to an actual suggestion. > > Never mind, it appears the existing magic in elf/Makefile takes care of the details. Yeah, you never need to worry about dynamic-linker stack-protection interactions in any directory because of that magic. It's static libc init that poses problems for csu/, hence the hardwired disabling of the stack-protector in csu/ for that case. (Though, as you noted in a review, that also unfortunately catches any tests in that directory). -- NULL && (void)