From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Florian Weimer <fw@deneb.enyo.de>
Cc: Wainer dos Santos Moschetta <wainersm@linux.vnet.ibm.com>,
libc-alpha@sourceware.org
Subject: Re: [PATCH] Update elf tests to use the support test driver.
Date: Thu, 30 Mar 2017 21:00:00 -0000 [thread overview]
Message-ID: <8811f9df-d9e2-229d-0380-4ee935be19a7@linaro.org> (raw)
In-Reply-To: <87mvc2scv8.fsf@mid.deneb.enyo.de>
On 30/03/2017 17:55, Florian Weimer wrote:
> * Adhemerval Zanella:
>
>> There is no need to remove the static definition from this function and
>> for all other every tests which includes the test-driver.c (since it will
>> end up creating the main entrypoint anyway). I would avoid change it.
>
> Agreed. The corresponding ChangeLog bit looks a bit strange as well:
>
> * elf/next.c: Import support/test-driver.c instead of
> test-skeleton.c and delete TEST_FUNCTION macro definition.
> (do_test): adjust return attribute.
> * elf/nodelete.c: Likewise.
>
> I don't think any function attribute is changed in the patch.
>
Also, if you have time I would ask you if you can update the Testing
wiki page onthe 'Writing a test case' [1]. It would be good to just
have it aligned with current practices.
[1] https://sourceware.org/glibc/wiki/Testing/Testsuite.
next prev parent reply other threads:[~2017-03-30 21:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-29 15:14 Wainer dos Santos Moschetta
2017-03-30 20:52 ` Adhemerval Zanella
2017-03-30 20:55 ` Florian Weimer
2017-03-30 21:00 ` Adhemerval Zanella [this message]
2017-03-30 21:01 ` Florian Weimer
2017-03-31 20:53 ` Wainer dos Santos Moschetta
2017-04-01 6:58 ` Florian Weimer
2017-04-01 13:58 ` Zack Weinberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8811f9df-d9e2-229d-0380-4ee935be19a7@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=fw@deneb.enyo.de \
--cc=libc-alpha@sourceware.org \
--cc=wainersm@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).