From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 9FD963858D1E for ; Mon, 6 May 2024 13:01:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9FD963858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9FD963858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715000519; cv=none; b=NIBMcUYjSJAvUybE1LDNAqRBdY7Naz5CGgsmSC2hxeRiktZjnXHmTnTm9XKMrUcbbKYh1+bS1DsFwyJT6IbWM/t8OIjcbHEGQtNfJIaQ0CsGLLUWXTbBjF7AjUWUAEEqX2spYiH5Dei7/ofpNIrUtPyr13m696dxJ+tcB50kkes= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715000519; c=relaxed/simple; bh=3R+0syqPW2Ma/qJh888sod2Or6UKRdrXjlC6R5bkDJ0=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:From:To; b=U9XGOLAcd7kDEPpoGv9S7Ch12PmoQTfZ48ENQUGtJAinaDDK4x7dP+tWhtLaCxBpzPGiPFwNBaPDzOdloSoSo22NvhXWrHVVJ1Ph2WW43tJG65O+en09jkd9twBJNoI73Kngnm7FgO7EBhUUei3fBOBXy8dYFqeR/iSlFpuIjZk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 446CoF5Y007953; Mon, 6 May 2024 13:01:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : from : to : cc : references : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=1F32GFcfXx0fLL8LeOEr3z8x+hjT1ufCZxvsGf6VZII=; b=jDtbfNOpEKoUOHe9T8pyHxnHrAaLHCBFvnmiufT5QP+3kA/ThZC5+9zqi4kQX+UU2PK7 Oq5mwt1Nzklt1xNgO1K+P4fCaYrcljuBbfaxSwhqWPT8ScWN0y/qZQFMrrCUS3o757pD VvtQH7a0WR+MXJBReukhNOUpEYnhKGxYcSAnVDvw7FV+9CYFxjdQCdqN197dFZS1GV1A t3yaQ5uBjiCxhkk4cMMFQR0plJs/GsXA436iiNFqIFMd0chJm4eosIEdSjvGymHcnx4j plM3APoEUNopbE/kYakHAUzk2hs2KQOqVfUvX/z71JYRm95cfzDVO7i2JnxAq6STGM1f gQ== Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3xxyj60168-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 May 2024 13:01:56 +0000 Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 446AKEVw022444; Mon, 6 May 2024 13:01:55 GMT Received: from smtprelay03.dal12v.mail.ibm.com ([172.16.1.5]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 3xx1jkqns8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 May 2024 13:01:55 +0000 Received: from smtpav05.dal12v.mail.ibm.com (smtpav05.dal12v.mail.ibm.com [10.241.53.104]) by smtprelay03.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 446D1qRq6685324 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 6 May 2024 13:01:55 GMT Received: from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D821158069; Mon, 6 May 2024 13:01:52 +0000 (GMT) Received: from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7BC6558070; Mon, 6 May 2024 13:01:52 +0000 (GMT) Received: from [9.61.161.194] (unknown [9.61.161.194]) by smtpav05.dal12v.mail.ibm.com (Postfix) with ESMTP; Mon, 6 May 2024 13:01:52 +0000 (GMT) Message-ID: <8821344d-23eb-4983-b417-55f05268c7de@linux.ibm.com> Date: Mon, 6 May 2024 08:01:52 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [V3] powerpc: Optimized strncmp for power10 From: Peter Bergner To: Amrita H S Cc: libc-alpha@sourceware.org, Paul E Murphy , Adhemerval Zanella References: <20240429095847.3541150-1-amritahs@linux.vnet.ibm.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: cOhrtumNFZVa_X4_RGaT8pLV5v-DRVWW X-Proofpoint-ORIG-GUID: cOhrtumNFZVa_X4_RGaT8pLV5v-DRVWW X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1011,Hydra:6.0.650,FMLib:17.11.176.26 definitions=2024-05-06_08,2024-05-06_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 suspectscore=0 adultscore=0 impostorscore=0 mlxscore=0 malwarescore=0 phishscore=0 clxscore=1015 spamscore=0 bulkscore=0 priorityscore=1501 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000 definitions=main-2405060090 X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,KAM_NUMSUBJECT,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 5/3/24 4:31 PM, Peter Bergner wrote: > This code looks like it assumes the kernel is using a 4k page size. > All distros that I know of and the default kernel config for ppc64 > and ppc64le kernels is to use a 64K HW page size. Is there a reason > we're not checking for a 64k cache boundary here? Talking with one of our kernel developers, there are a couple of minor Linux distros building ppc64* kernels with 4K pages, so that answers my question why we're using that here. A good future project would be to either have a configure option to state the page size to use or detect it at runtime from the AT_PAGESZ AUXV entry and choose the right routine. Either way, this current patch... LGTM. Reviewed-by: Peter Bergner I'll take care of updating the Copyright dates and merging it for you. Thanks! Peter