From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from xry111.site (xry111.site [89.208.246.23]) by sourceware.org (Postfix) with ESMTPS id AE1843858403 for ; Mon, 25 Jul 2022 08:01:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AE1843858403 Received: from localhost.localdomain (xry111.site [IPv6:2001:470:683e::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-384) server-digest SHA384) (Client did not present a certificate) (Authenticated sender: xry111@xry111.site) by xry111.site (Postfix) with ESMTPSA id 85167667DA; Mon, 25 Jul 2022 04:01:09 -0400 (EDT) Message-ID: <887137f5f1aada4363e6106a1eacdf17449155fc.camel@xry111.site> Subject: Re: Re: [PATCH v7 00/13] GLIBC LoongArch PATCHES From: Xi Ruoyao To: =?gb2312?Q?=C1=F5=D5=F1=CB=C9?= Cc: WANG Xuerui , caiyinyu , adhemerval.zanella@linaro.org, libc-alpha@sourceware.org, joseph_myers@mentor.com, carlos@redhat.com Date: Mon, 25 Jul 2022 16:01:07 +0800 In-Reply-To: <6e4016e7.8a14.1823313f163.Coremail.liuzhensong@loongson.cn> References: <20220719012056.1461897-1-caiyinyu@loongson.cn> <71ad82b8b669d4233b7fd4741add7b58bd7ac20e.camel@xry111.site> <6e4016e7.8a14.1823313f163.Coremail.liuzhensong@loongson.cn> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.3 MIME-Version: 1.0 X-Spam-Status: No, score=0.6 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FROM_SUSPICIOUS_NTLD, LIKELY_SPAM_FROM, PDS_OTHER_BAD_TLD, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Jul 2022 08:01:15 -0000 On Mon, 2022-07-25 at 09:58 +0800, =E5=88=98=E6=8C=AF=E6=9D=BE wrote: > > +Zhensong: is there any possibility to merge this patch for binutils > > master and 2.39 release branch (including 2.38 release branch would be > > even better) so at least glibc ifunc tests will be happy? >=20 > This patch alone has not been fully tested=EF=BC=8C some ifunc implementa= tions rely on new modifications. > If there is no problem with the tests, it can be merged into other branch= s. Binutils tests OK with the change. I had to introduce "alt_got" and "alt_off" (not in your original patch) when I extracted the patch out of the series, with changes like: - bfd_put_NN (output_bfd, relocation, got->contents + off); + bfd_put_NN (output_bfd, relocation, alt_got->contents + alt_off); It's because if something is not in .got section, referring it with got->contents + off will cause a heap buffer overflow even if off is correct. If the full series of your patch is applied, this seems not happening. But with only this patch, we need to prevent it. --=20 Xi Ruoyao School of Aerospace Science and Technology, Xidian University