From: Siddhesh Poyarekar <siddhesh@sourceware.org>
To: Paul Zimmermann <Paul.Zimmermann@inria.fr>
Cc: libc-alpha@sourceware.org, joseph@codesourcery.com
Subject: Re: [COMMITTED] ieee754: Remove slow paths from asin and acos
Date: Fri, 18 Dec 2020 14:56:32 +0530 [thread overview]
Message-ID: <887f2ffc-76f8-d027-a9a9-11eef01ed0b3@sourceware.org> (raw)
In-Reply-To: <mwo8ir34dg.fsf@tomate.loria.fr>
On 12/18/20 1:58 PM, Paul Zimmermann wrote:
> Hi,
>
>> Date: Fri, 18 Dec 2020 12:39:26 +0530
>> From: Siddhesh Poyarekar via Libc-alpha <libc-alpha@sourceware.org>
>>
>> Looks like this patchset was approved but never committed. I have
>> pushed it now:
>>
>> https://sourceware.org/pipermail/glibc-cvs/2020q4/071274.html
>> https://sourceware.org/pipermail/glibc-cvs/2020q4/071275.html
>>
>> Siddhesh
>
> note that acos() was not correctly rounded before (x=0x1.fffff3634acd6p-1
> gave an error of 0.5000000044534775 ulps [1]).
That seems within an acceptable range for glibc; some years ago we gave
up trying to be correctly rounded.
> I did run "make bench" in 2.32 and after those patches.
>
> 2.32:
> "acos": {
> "": {
> "duration": 3.63669e+09,
> "iterations": 2.43e+07,
> "max": 892.2,
> "min": 15.357,
> "mean": 149.658
> },
> "asin": {
> "": {
> "duration": 3.58039e+09,
> "iterations": 2.5e+07,
> "max": 488.568,
> "min": 15.231,
> "mean": 143.216
> },
>
> after:
> "acos": {
> "": {
> "duration": 3.65234e+09,
> "iterations": 2.43e+07,
> "max": 1015,
> "min": 15.456,
> "mean": 150.302
> },
> "asin": {
> "": {
> "duration": 3.61159e+09,
> "iterations": 2.5e+07,
> "max": 1011.85,
> "min": 16.131,
> "mean": 144.464
> },
>
> It does not seem the maximal time did decrease. Can someone else check?
>
That may just be due to the slow inputs not being represented in the
synthetic workload in the benchmark; IIRC I had auto-generated a random
set for the non-mp paths.
Siddhesh
prev parent reply other threads:[~2020-12-18 9:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-27 10:45 [PATCH 1/2] " Anssi Hannula
2020-01-27 11:25 ` [PATCH 2/2] ieee754: Remove unused __sin32 and __cos32 Anssi Hannula
2020-01-27 13:12 ` [PATCH 1/2] ieee754: Remove slow paths from asin and acos Szabolcs Nagy
2020-01-28 10:51 ` Anssi Hannula
2020-03-24 23:15 ` Joseph Myers
2020-12-18 7:09 ` [COMMITTED] " Siddhesh Poyarekar
2020-12-18 8:28 ` Paul Zimmermann
2020-12-18 9:26 ` Siddhesh Poyarekar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=887f2ffc-76f8-d027-a9a9-11eef01ed0b3@sourceware.org \
--to=siddhesh@sourceware.org \
--cc=Paul.Zimmermann@inria.fr \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).