From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x742.google.com (mail-qk1-x742.google.com [IPv6:2607:f8b0:4864:20::742]) by sourceware.org (Postfix) with ESMTPS id 14CA638618BD for ; Wed, 2 Dec 2020 14:27:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 14CA638618BD Received: by mail-qk1-x742.google.com with SMTP id q5so1287298qkc.12 for ; Wed, 02 Dec 2020 06:27:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:autocrypt:subject :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=/N73VWoJArnR7YzBZ3SwhhuNaej80t/sidAM6Ngxg5g=; b=JRqvYD/8Ow9RoKoyIHZi7XqvdEhAyS/0wJ0io5+sRzJQLP3CcdzFb/Mv/bOzxcDTav /8vK6HevxEPI4Urp5iCj7MpPztYMY8Y1+3oTYcah7NoDK4gx6Q3I1Z3/6+dlUoxF4kmH enWENLZT4mKqUuZa4k6I9qd3UKcXlv6t5kwoNhsLADLedi5KiiBx/HleKL3UqJ2IZf8R U7dmsKvZmXimxhIUpCbJCHcEf6drel8hHY/jWbSdyINfOhhiIe6avYVhzdSwQ42TVvSe 7WmvCwFLHss56gS5bwroVBkNDg0A2mo6gh2JpUtS2rV5lFIuLw3025b+ibW/+O+M7gju J+8A== X-Gm-Message-State: AOAM531FbYNCTV+DvfBSGH1CxtQIza9GZ3j1joGDYgRnIpxMwDLA03hO qqnO+OKVNe4OnufBNf+3btmVChpG5PBpEQ== X-Google-Smtp-Source: ABdhPJzE3dTRIM0a1NXffh8TtA0zpW7YPpE29JrhG3AKAqqzzOpAy9DVMcJEnD7Z1oNZCXt/byYSCg== X-Received: by 2002:ae9:ed81:: with SMTP id c123mr2710380qkg.349.1606919268337; Wed, 02 Dec 2020 06:27:48 -0800 (PST) Received: from [192.168.1.4] ([177.194.48.209]) by smtp.googlemail.com with ESMTPSA id t133sm1805225qke.82.2020.12.02.06.27.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Dec 2020 06:27:47 -0800 (PST) To: Florian Weimer Cc: libc-alpha@sourceware.org References: <38719cefeb0737c1640f749177e6f0902890cf3d.1604946656.git.fweimer@redhat.com> <87h7p471ug.fsf@oldenburg2.str.redhat.com> From: Adhemerval Zanella Autocrypt: addr=adhemerval.zanella@linaro.org; prefer-encrypt=mutual; keydata= mQINBFcVGkoBEADiQU2x/cBBmAVf5C2d1xgz6zCnlCefbqaflUBw4hB/bEME40QsrVzWZ5Nq 8kxkEczZzAOKkkvv4pRVLlLn/zDtFXhlcvQRJ3yFMGqzBjofucOrmdYkOGo0uCaoJKPT186L NWp53SACXguFJpnw4ODI64ziInzXQs/rUJqrFoVIlrPDmNv/LUv1OVPKz20ETjgfpg8MNwG6 iMizMefCl+RbtXbIEZ3TE/IaDT/jcOirjv96lBKrc/pAL0h/O71Kwbbp43fimW80GhjiaN2y WGByepnkAVP7FyNarhdDpJhoDmUk9yfwNuIuESaCQtfd3vgKKuo6grcKZ8bHy7IXX1XJj2X/ BgRVhVgMHAnDPFIkXtP+SiarkUaLjGzCz7XkUn4XAGDskBNfbizFqYUQCaL2FdbW3DeZqNIa nSzKAZK7Dm9+0VVSRZXP89w71Y7JUV56xL/PlOE+YKKFdEw+gQjQi0e+DZILAtFjJLoCrkEX w4LluMhYX/X8XP6/C3xW0yOZhvHYyn72sV4yJ1uyc/qz3OY32CRy+bwPzAMAkhdwcORA3JPb kPTlimhQqVgvca8m+MQ/JFZ6D+K7QPyvEv7bQ7M+IzFmTkOCwCJ3xqOD6GjX3aphk8Sr0dq3 4Awlf5xFDAG8dn8Uuutb7naGBd/fEv6t8dfkNyzj6yvc4jpVxwARAQABtElBZGhlbWVydmFs IFphbmVsbGEgTmV0dG8gKExpbmFybyBWUE4gS2V5KSA8YWRoZW1lcnZhbC56YW5lbGxhQGxp bmFyby5vcmc+iQI3BBMBCAAhBQJXFRpKAhsDBQsJCAcDBRUKCQgLBRYCAwEAAh4BAheAAAoJ EKqx7BSnlIjv0e8P/1YOYoNkvJ+AJcNUaM5a2SA9oAKjSJ/M/EN4Id5Ow41ZJS4lUA0apSXW NjQg3VeVc2RiHab2LIB4MxdJhaWTuzfLkYnBeoy4u6njYcaoSwf3g9dSsvsl3mhtuzm6aXFH /Qsauav77enJh99tI4T+58rp0EuLhDsQbnBic/ukYNv7sQV8dy9KxA54yLnYUFqH6pfH8Lly sTVAMyi5Fg5O5/hVV+Z0Kpr+ZocC1YFJkTsNLAW5EIYSP9ftniqaVsim7MNmodv/zqK0IyDB GLLH1kjhvb5+6ySGlWbMTomt/or/uvMgulz0bRS+LUyOmlfXDdT+t38VPKBBVwFMarNuREU2 69M3a3jdTfScboDd2ck1u7l+QbaGoHZQ8ZNUrzgObltjohiIsazqkgYDQzXIMrD9H19E+8fw kCNUlXxjEgH/Kg8DlpoYJXSJCX0fjMWfXywL6ZXc2xyG/hbl5hvsLNmqDpLpc1CfKcA0BkK+ k8R57fr91mTCppSwwKJYO9T+8J+o4ho/CJnK/jBy1pWKMYJPvvrpdBCWq3MfzVpXYdahRKHI ypk8m4QlRlbOXWJ3TDd/SKNfSSrWgwRSg7XCjSlR7PNzNFXTULLB34sZhjrN6Q8NQZsZnMNs TX8nlGOVrKolnQPjKCLwCyu8PhllU8OwbSMKskcD1PSkG6h3r0AquQINBFcVGkoBEACgAdbR Ck+fsfOVwT8zowMiL3l9a2DP3Eeak23ifdZG+8Avb/SImpv0UMSbRfnw/N81IWwlbjkjbGTu oT37iZHLRwYUFmA8fZX0wNDNKQUUTjN6XalJmvhdz9l71H3WnE0wneEM5ahu5V1L1utUWTyh VUwzX1lwJeV3vyrNgI1kYOaeuNVvq7npNR6t6XxEpqPsNc6O77I12XELic2+36YibyqlTJIQ V1SZEbIy26AbC2zH9WqaKyGyQnr/IPbTJ2Lv0dM3RaXoVf+CeK7gB2B+w1hZummD21c1Laua +VIMPCUQ+EM8W9EtX+0iJXxI+wsztLT6vltQcm+5Q7tY+HFUucizJkAOAz98YFucwKefbkTp eKvCfCwiM1bGatZEFFKIlvJ2QNMQNiUrqJBlW9nZp/k7pbG3oStOjvawD9ZbP9e0fnlWJIsj 6c7pX354Yi7kxIk/6gREidHLLqEb/otuwt1aoMPg97iUgDV5mlNef77lWE8vxmlY0FBWIXuZ yv0XYxf1WF6dRizwFFbxvUZzIJp3spAao7jLsQj1DbD2s5+S1BW09A0mI/1DjB6EhNN+4bDB SJCOv/ReK3tFJXuj/HbyDrOdoMt8aIFbe7YFLEExHpSk+HgN05Lg5TyTro8oW7TSMTk+8a5M kzaH4UGXTTBDP/g5cfL3RFPl79ubXwARAQABiQIfBBgBCAAJBQJXFRpKAhsMAAoJEKqx7BSn lIjvI/8P/jg0jl4Tbvg3B5kT6PxJOXHYu9OoyaHLcay6Cd+ZrOd1VQQCbOcgLFbf4Yr+rE9l mYsY67AUgq2QKmVVbn9pjvGsEaz8UmfDnz5epUhDxC6yRRvY4hreMXZhPZ1pbMa6A0a/WOSt AgFj5V6Z4dXGTM/lNManr0HjXxbUYv2WfbNt3/07Db9T+GZkpUotC6iknsTA4rJi6u2ls0W9 1UIvW4o01vb4nZRCj4rni0g6eWoQCGoVDk/xFfy7ZliR5B+3Z3EWRJcQskip/QAHjbLa3pml xAZ484fVxgeESOoaeC9TiBIp0NfH8akWOI0HpBCiBD5xaCTvR7ujUWMvhsX2n881r/hNlR9g fcE6q00qHSPAEgGr1bnFv74/1vbKtjeXLCcRKk3Ulw0bY1OoDxWQr86T2fZGJ/HIZuVVBf3+ gaYJF92GXFynHnea14nFFuFgOni0Mi1zDxYH/8yGGBXvo14KWd8JOW0NJPaCDFJkdS5hu0VY 7vJwKcyHJGxsCLU+Et0mryX8qZwqibJIzu7kUJQdQDljbRPDFd/xmGUFCQiQAncSilYOcxNU EMVCXPAQTteqkvA+gNqSaK1NM9tY0eQ4iJpo+aoX8HAcn4sZzt2pfUB9vQMTBJ2d4+m/qO6+ cFTAceXmIoFsN8+gFN3i8Is3u12u8xGudcBPvpoy4OoG Subject: Re: [PATCH 11/11] powerpc64le: Add glibc-hwcaps support Message-ID: <887f5bfe-a8b6-3c52-cc11-5610b237ed87@linaro.org> Date: Wed, 2 Dec 2020 11:27:45 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <87h7p471ug.fsf@oldenburg2.str.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Dec 2020 14:27:50 -0000 On 02/12/2020 10:51, Florian Weimer wrote: > * Adhemerval Zanella: > >>> +uint32_t >>> +_dl_hwcaps_subdirs_active (void) >>> +{ >>> + int active = 0; >>> + >>> + /* Test in reverse preference order. Altivec and VSX are implied by >>> + the powerpc64le ABI definition. */ >>> + >>> + /* POWER9. GCC enables float128 hardware support for -mcpu=power9. */ >>> + if ((GLRO (dl_hwcap2) & PPC_FEATURE2_ARCH_3_00) == 0 >>> + || (GLRO (dl_hwcap2) & PPC_FEATURE2_HAS_IEEE128) == 0) >>> + return _dl_hwcaps_subdirs_build_bitmask (subdirs_count, active); >>> + ++active; >> >> Should we test PPC_FEATURE2_DARN as well? I think cryptographic and related >> libraries might use it as source of entropy. > > It does not show up in the compiler preprocessor macros. There also > have been cases where randomness-generating instructions have been > disabled in firmware (but probably not on POWER). I think it's safer > not to include cryptographic stuff. GCC does provides it through a compiler builtin, only enabled for power9 and newer. And I think hardware entropy instruction are not used on cryptographic, but also on different fields as simulations. > >>> + >>> + /* POWER10. GCC defines __MMA__ for -mcpu=power10. */ >> >> Double space after period. > > Thanks, fixed. > >>> +/* Return the POWER level, 8 for the baseline. */ >>> +static int >>> +compute_level (void) >>> +{ >>> + const char *platform = (const char *) getauxval (AT_PLATFORM); >>> + if (strcmp (platform, "power8") == 0) >>> + return 8; >>> + if (strcmp (platform, "power9") == 0) >>> + return 9; >>> + if (strcmp (platform, "power10") == 0) >>> + return 10; >> >> Why not use HWCAP? Is it to decouple from the loader code that uses it? >> I am asking because by using hwcap we can check if this tests is working >> on different chips by using qemu-ppc64le with -mcpu. > > And that doesn't affect AT_PLATFORM? That would be a QEMU bug. At least not with v5.2.0-rc0-99-g3493c36f03, not sure if is has been fixed/change upstream.