From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 49451 invoked by alias); 14 Nov 2019 17:47:27 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 49442 invoked by uid 89); 14 Nov 2019 17:47:27 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-10.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.1 spammy=people's, peoples, neat, HTo:D*net.br X-HELO: mx0a-001b2d01.pphosted.com Subject: Re: [PATCH v2 15/30] ldbl-128ibm-compat: Add syslog functions To: "Gabriel F. T. Gomes" , libc-alpha@sourceware.org References: <20191025153410.15405-1-gabriel@inconstante.net.br> <20191025153410.15405-16-gabriel@inconstante.net.br> From: Paul E Murphy Message-ID: <888e1f49-ed97-1941-bd28-b9d74192507e@linux.ibm.com> Date: Thu, 14 Nov 2019 17:47:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 MIME-Version: 1.0 In-Reply-To: <20191025153410.15405-16-gabriel@inconstante.net.br> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2019-11/txt/msg00560.txt.bz2 On 10/25/19 10:33 AM, Gabriel F. T. Gomes wrote: > From: "Gabriel F. T. Gomes" > > Changes since v1: > > - Moved the test to a container, which stopped messages being written > to the system log. > > Comment from v1: > > I'm using 'syslog (LOG_DEBUG, etc.);' and support_capture_subprocess in > the test case, which I believe will not print to the console, but I'm > not sure if changing some system setting to high verbosity will disturb > people's lives. Please advise. :) > > -- 8< -- > Similarly to __vfprintf_internal and __vfscanf_internal, the internal > implementation of syslog functions (__vsyslog_internal) takes a > 'mode_flags' parameter used to select the format of long double > parameters. This patch adds variants of the syslog functions that set > 'mode_flags' to PRINTF_LDBL_USES_FLOAT128, thus enabling the correct > printing of long double values on powerpc64le, when long double has IEEE > binary128 format (-mabi=ieeelongdouble). > > Tested for powerpc64le. glibc has containers these days, neat. This looks OK to me and addresses the feedback from v1.