Re: [PATCH] rtld: Add --no-default-paths option

[Carlos O'Donell <carlos@redhat.com>]

On 5/24/21 11:22 PM, Mike Frysinger via Libc-alpha wrote:
> On 25 May 2021 12:25, Fergus Dall via Libc-alpha wrote:
>> This option implies --inhibit-cache, as there is no point
>> in searching a cache of system libraries when we are not using the
>> system libraries at all.
> 
> i'm on the fence about this.  i don't disagree with your logic, but it
> still seems like we have a dedicated --inhibit-cache option, so might as
> well leave it at that.
> 
> logic-wise, code seems OK.  would be nice to add a test, but this is a bit
> hard as it relies on the installed / paths.

We have containerized tests now that can use installed paths.

We have tests for corrupted cache, NSS, localedef invocation etc. all that
depend on installed paths to trigger the specific code.

We *should* be creating tests in all of the cases where we lacked them
before because of installed path problems.

> 
>> +int _dl_no_default_paths;
> 
> i try to avoid negative variables as it makes reading code harder.
> how about "_dl_search_default_paths" ?
> 
>> --- a/elf/dl-usage.c
>> +++ b/elf/dl-usage.c
>>
>> +  --no-default-paths    Do not use the default library search path\n\a
>> +                        This option implies --inhibit-cache\n\
> 
> prob should read:
>   --no-default-paths    do not use the default library search path\n\a
>                         (this option implies --inhibit-cache)\n\
> -mike
> 


-- 
Cheers,
Carlos.