From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by sourceware.org (Postfix) with ESMTP id 797553858D35 for ; Sat, 8 Aug 2020 04:42:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 797553858D35 Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-229-WNyCqXk3PKS7Zz2HLK7wmQ-1; Sat, 08 Aug 2020 00:42:28 -0400 X-MC-Unique: WNyCqXk3PKS7Zz2HLK7wmQ-1 Received: by mail-qt1-f197.google.com with SMTP id u17so3256401qtq.13 for ; Fri, 07 Aug 2020 21:42:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=fa9I5Z/AnqyQ/BXCQiDyViJrxEDIKeoaavnXETTIsWE=; b=ppj3FmsBzj5HHMwk4qLxgUKNhiDUYVkJ8Xe7WQaUl4JZBqRJMzLGy1uBP2UBUWtxak rE/9a67saYCvH3YRav9Ffwb8k34gq+7xFqGw5V656pNpGDms+3rHTPLpHGBbg/8VKlxZ thkW4YTLa+XSNCgv+m1IoLeXMSDQrkHgxr3bxlXGHUYXvf25a9dy0wryoGSISbcCaRHv b18e+5ubfik3DFsDhMPGq4DftMlUekT8drSE9z6uNnFunNknL4Hoq3g4nRk3woeXFv57 8AeI/xNyTYoE9o1PGs+aKGJyqlBE9bRJ+NadpCx2YNLsyWnbKzZRoRyRDFTVrzEdEWaA 3DLQ== X-Gm-Message-State: AOAM533ZXZFtw9EQoHr3tL2FyC9Iux5nCCVW0fUqgTVUnScBlarx1m8j zgcO4ZZxSbp5HaF9Hp5Hl5VCcrvZeJIiB8xdVvulKET07do9dE9uPy8r657xsLhq7Ll7vug1/Wx wxalrtskO3akADvBr8hPy X-Received: by 2002:a0c:e30c:: with SMTP id s12mr18436234qvl.138.1596861748058; Fri, 07 Aug 2020 21:42:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxmzxaGZwStctJwtxKBbkxgbPBkkBXlmhX2PhOhl2vmzBP0z98k415vxCwjY5tmPqGex/sM2w== X-Received: by 2002:a0c:e30c:: with SMTP id s12mr18436223qvl.138.1596861747725; Fri, 07 Aug 2020 21:42:27 -0700 (PDT) Received: from [192.168.1.16] (198-84-214-74.cpe.teksavvy.com. [198.84.214.74]) by smtp.gmail.com with ESMTPSA id x67sm8611223qke.136.2020.08.07.21.42.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Aug 2020 21:42:26 -0700 (PDT) Subject: Re: [PATCH v3 1/2] BZ #17645, fix slow DSO sorting behavior in dynamic loader From: Carlos O'Donell To: cltang@codesourcery.com, Andreas Schwab Cc: GNU C Library , Catherine Moore References: <87a724uhtf.fsf@igel.home> <87tv0ct1vl.fsf@igel.home> <456fbddc-7915-19da-3ffe-e58b86ae7980@redhat.com> <1427b370-7400-afd0-16e8-55c1072db20e@mentor.com> Organization: Red Hat Message-ID: <896c4a49-2579-ad3e-aa80-d918260c68b2@redhat.com> Date: Sat, 8 Aug 2020 00:42:26 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Aug 2020 04:42:31 -0000 On 7/26/20 8:40 PM, Carlos O'Donell wrote: > On 7/22/20 2:10 PM, Chung-Lin Tang wrote: >> I only now notice that "permute" vs "permutate" is an issue :) I've corrected the >> spelling as you've suggested. >> >> The v3 patch is attached, please see if this is now okay for committing. > > I'm going to review this shortly, but it's too late in the release to add it to 2.32. > > My plan, if you agree, is as follows: > > (a) Review this promptly this week. > (b) Switch the sense of the default to just use the new DFS sort. > (c) Open 2.33 for development and commit the changes. > (d) Sync Fedora Rawhide and spend the next 5 months testing this in Rawhide. > > There are still a few more changes we need to make in the test generation, > for example the tests don't use support/test-driver.c which means they could > hang the entire testsuite and they don't support timeouts because of this. > > We should follow generating the test such that the executable uses test-drive.c > like all new tests should. This way we can catch tests that used to take 200s > and now take 1s (default timeout at 20s). This is still on my plate to review along with DJ's nsswitch.conf changes. -- Cheers, Carlos.