From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id C51993858D28 for ; Fri, 25 Feb 2022 15:29:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C51993858D28 Received: from mail-io1-f69.google.com (mail-io1-f69.google.com [209.85.166.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-43-eAazHyylM3SppRTZuOBnMw-1; Fri, 25 Feb 2022 10:29:23 -0500 X-MC-Unique: eAazHyylM3SppRTZuOBnMw-1 Received: by mail-io1-f69.google.com with SMTP id g16-20020a05660226d000b00638d8e1828bso3992929ioo.13 for ; Fri, 25 Feb 2022 07:29:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:organization:in-reply-to :content-transfer-encoding; bh=n3I/tJ1Dft/XByFb+n0X6XE2N0umVlcnnLB7aAf/+n4=; b=BLg0u4DT4hcUSpF14fZ3gopB4eA0ehgt79+GV8Y3dew/0zPiuoCu2l3Y5pNpoiU9d1 Xy/d6YWzQ4jdMSy8f60iX24mTy4AhLbAmqQlPCV6mY4D188Lqqxt3udWnqgauDTniwH1 /bjsn0bCD7hrNln1wdPhGTs6tu4Je/XjhuyhHa8QKNTuQX1J0gaPFo6SBiCCLLRJzXW7 nEgTH/cXssCcjGuCXHgy8Vl9LaWuVERVI1dYtnmJaPAIrVU5so6NkGgUUe+0+rxU0FNq diOepPabKdKE55nMjBzx0xOs8Esle+p+9S3+kOgUcpzFZHQbSHIe8vGZI3OsBGR8G9Hh +AjQ== X-Gm-Message-State: AOAM533zyfaAUkvtu6Y2Xgka+TLlsNrLW3leOvUefI29RV9fxZ7wS28c SCzxoBuBIJ2IxiO6EGvz1n9Z25+ohP406143m2whpyBF3KzpQ9mNS/TKsOVoO01KWbGz6xPWHA4 JlYrrPmX7A2e/Os2mRF2/ X-Received: by 2002:a05:6638:502:b0:30e:4b0c:55cf with SMTP id i2-20020a056638050200b0030e4b0c55cfmr6214256jar.11.1645802963170; Fri, 25 Feb 2022 07:29:23 -0800 (PST) X-Google-Smtp-Source: ABdhPJz/xMz+eK+8+OdqRrVzUvu1E1bQel/80oOpGEwp569a2jEfY/AAIH/WYiDm8daVDLauRCHWRA== X-Received: by 2002:a05:6638:502:b0:30e:4b0c:55cf with SMTP id i2-20020a056638050200b0030e4b0c55cfmr6214232jar.11.1645802962732; Fri, 25 Feb 2022 07:29:22 -0800 (PST) Received: from [192.168.0.241] (135-23-175-80.cpe.pppoe.ca. [135.23.175.80]) by smtp.gmail.com with ESMTPSA id y4-20020a056e02118400b002c274deca4esm1747267ili.0.2022.02.25.07.29.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Feb 2022 07:29:22 -0800 (PST) Message-ID: <89dc4ec7-b0e6-fcc1-9686-892945e72ff3@redhat.com> Date: Fri, 25 Feb 2022 10:29:21 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH v2] build: Properly generate .d dependency files [BZ #28922] To: "H.J. Lu" , libc-alpha@sourceware.org References: <20220224221045.987117-1-hjl.tools@gmail.com> From: Carlos O'Donell Organization: Red Hat In-Reply-To: <20220224221045.987117-1-hjl.tools@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Feb 2022 15:29:31 -0000 On 2/24/22 17:10, H.J. Lu via Libc-alpha wrote: > 1. Also generate .d dependency files for $(tests-container) and > $(tests-printers). > 2. elf: Add tst-auditmod17.os to extra-test-objs. > 3. iconv: Add tst-gconv-init-failure-mod.os to extra-test-objs. > 4. malloc: Rename extra-tests-objs to extra-test-objs. > 5. linux: Add tst-sysconf-iov_max-uapi.o to extra-test-objs. > 6. x86_64: Add tst-x86_64mod-1.o, tst-platformmod-2.o, test-libmvec.o, > test-libmvec-avx.o, test-libmvec-avx2.o and test-libmvec-avx512f.o to > extra-test-objs. LGTM. Thanks for fixing the libmvec things at the source of their definition in libmvec.mk. Reviewed-by: Carlos O'Donell > --- > Makerules | 1 + > elf/Makefile | 3 +++ > iconv/Makefile | 1 + > malloc/Makefile | 2 +- > sysdeps/unix/sysv/linux/Makefile | 3 +++ > sysdeps/x86_64/Makefile | 2 ++ > sysdeps/x86_64/fpu/Makeconfig | 6 ++++++ > 7 files changed, 17 insertions(+), 1 deletion(-) > > diff --git a/Makerules b/Makerules > index 5de2cec6be..428464f092 100644 > --- a/Makerules > +++ b/Makerules > @@ -770,6 +770,7 @@ endif > $(patsubst %.oS,%.d,$(filter %.oS,$(extra-objs))) \ > $(patsubst %.o,%.d,$(filter %.o,$(extra-test-objs:.os=.o))) \ > $(addsuffix .d,$(tests) $(tests-internal) $(xtests) \ > + $(tests-container) $(tests-printers) \ OK. > $(test-srcs) $(tests-time64) $(xtests-time64)) > ifeq ($(build-programs),yes) > +depfiles += $(addsuffix .d,$(others) $(sysdep-others)) > diff --git a/elf/Makefile b/elf/Makefile > index bff94954c9..281551d380 100644 > --- a/elf/Makefile > +++ b/elf/Makefile > @@ -888,6 +888,9 @@ modules-names += \ > modules-names-tests = $(filter-out ifuncmod% tst-tlsmod%,\ > $(modules-names)) > > +# For +depfiles in Makerules. > +extra-test-objs += tst-auditmod17.os > + OK. > ifeq (yes,$(have-mtls-dialect-gnu2)) > tests += tst-gnu2-tls1 > modules-names += tst-gnu2-tls1mod > diff --git a/iconv/Makefile b/iconv/Makefile > index 5aeed346ef..a0d90cfeac 100644 > --- a/iconv/Makefile > +++ b/iconv/Makefile > @@ -86,6 +86,7 @@ ifeq (yes,$(build-shared)) > tests += tst-gconv-init-failure > modules-names += tst-gconv-init-failure-mod > modules-names-tests += tst-gconv-init-failure-mod > +extra-test-objs += tst-gconv-init-failure-mod.os OK. > $(objpfx)tst-gconv-init-failure-mod.so: $(libsupport) > $(objpfx)tst-gconv-init-failure.out: \ > $(objpfx)gconv-modules $(objpfx)tst-gconv-init-failure-mod.so > diff --git a/malloc/Makefile b/malloc/Makefile > index 2329cf718a..4e32de2a0b 100644 > --- a/malloc/Makefile > +++ b/malloc/Makefile > @@ -145,7 +145,7 @@ extra-libs = libmemusage libc_malloc_debug > extra-libs-others = $(extra-libs) > > # Helper objects for some tests. > -extra-tests-objs += \ > +extra-test-objs += \ OK. > tst-interpose-aux-nothread.o \ > tst-interpose-aux-thread.o \ > > diff --git a/sysdeps/unix/sysv/linux/Makefile b/sysdeps/unix/sysv/linux/Makefile > index 7122f55975..ca953804d0 100644 > --- a/sysdeps/unix/sysv/linux/Makefile > +++ b/sysdeps/unix/sysv/linux/Makefile > @@ -128,6 +128,9 @@ tests += tst-clone tst-clone2 tst-clone3 tst-fanotify tst-personality \ > tst-epoll \ > # tests > > +# For +depfiles in Makerules. > +extra-test-objs += tst-sysconf-iov_max-uapi.o > + OK. > # Test for the symbol version of fcntl that was replaced in glibc 2.28. > ifeq ($(have-GLIBC_2.27)$(build-shared),yesyes) > tests += tst-ofdlocks-compat > diff --git a/sysdeps/x86_64/Makefile b/sysdeps/x86_64/Makefile > index 7a4b576356..79365aff2a 100644 > --- a/sysdeps/x86_64/Makefile > +++ b/sysdeps/x86_64/Makefile > @@ -52,6 +52,7 @@ CFLAGS-tst-quad2pie.c = $(PIE-ccflag) > > tests += tst-x86_64-1 > modules-names += x86_64/tst-x86_64mod-1 > +extra-test-objs += tst-x86_64mod-1.o OK. > LDFLAGS-tst-x86_64mod-1.so = -Wl,-soname,tst-x86_64mod-1.so > ifneq (no,$(have-tunables)) > # Test the state size for XSAVE when XSAVEC is disabled. > @@ -63,6 +64,7 @@ $(objpfx)tst-x86_64-1: $(objpfx)x86_64/tst-x86_64mod-1.so > ifneq (no,$(have-tunables)) > tests += tst-platform-1 > modules-names += tst-platformmod-1 x86_64/tst-platformmod-2 > +extra-test-objs += tst-platformmod-2.o OK. > CFLAGS-tst-platform-1.c = -mno-avx > CFLAGS-tst-platformmod-1.c = -mno-avx > CFLAGS-tst-platformmod-2.c = -mno-avx > diff --git a/sysdeps/x86_64/fpu/Makeconfig b/sysdeps/x86_64/fpu/Makeconfig > index 30b8d97826..5c03b1dbb8 100644 > --- a/sysdeps/x86_64/fpu/Makeconfig > +++ b/sysdeps/x86_64/fpu/Makeconfig > @@ -112,6 +112,12 @@ libmvec-abi-func-avx512f-tests = \ > > $(common-objpfx)libmvec.mk: $(common-objpfx)config.make > (echo "ifeq (\$$(subdir)\$$(build-mathvec),mathyes)"; \ > + echo; \ > + echo "extra-test-objs += \\"; \ > + for i in "" "-avx" "-avx2" "-avx512f"; do \ > + echo " test-libmvec$$i.o \\"; \ > + done; \ > + echo "# extra-test-objs"; \ OK. *Perfect*! > echo; \ > for i in "" "-avx" "-avx2" "-avx512f"; do \ > for t in $(libmvec-abi-func-tests); do \ -- Cheers, Carlos.