From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vs1-xe33.google.com (mail-vs1-xe33.google.com [IPv6:2607:f8b0:4864:20::e33]) by sourceware.org (Postfix) with ESMTPS id DFE7F385483E for ; Fri, 30 Sep 2022 15:33:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DFE7F385483E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-vs1-xe33.google.com with SMTP id u189so5187383vsb.4 for ; Fri, 30 Sep 2022 08:33:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=0/TgpVUA07ezdu9pZCt8cys7cVIS4nlbz+DMOJrBb5g=; b=tncQ/hDAT7JSBfyjAXETl3+I0SblY/8P2Xrh9Kp2sed+WWNkdLZO73UEbw4WhGk5ph 3lhwn6Zd4lwbciFr6AqmwOnZ3AhbxSFiDnNwD19rgeuxiJWU+tkk+lgyg/CoxXLiXgVW mlqpwR4XyvLAy8CLzqbKKUG4MflREQL6KO7sd9xTvyOqPi0Q6YkSDe4oN8qnaHDb/3u5 3M27Di9ftO6nSovOfzu3wf0ZakZx0WypBiGBbRYzc4qF5ZovTcIyFqHSHVhhrwyIwmw7 hpIloOI9Aut2njbV1dnhX/J8CQha9uqnaEYQ+YLQBBbNvSbsMWGBIyBZe9GHYALyCGz+ kVZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=0/TgpVUA07ezdu9pZCt8cys7cVIS4nlbz+DMOJrBb5g=; b=iqB7m6nUf5o5he7k+ojYnwbM7znvmQFtJXRnAX9mJ80t3t0kERJV3LdU6AgPsB46ZQ jLeZrM8Vi9gZNC5rT4UdMMxmHUIn0zS45WOdqFX2Fn/948yTrceHigoAnD1blZJafV3l P+BKbPoji4tY6oYKWMHu7e+deOcuEl1AmGiJV1COZkNABesOLsQp2LLU9OghZCKaeZM3 1UyXJb5ILx1IJOrpt+wr3TkcCABJaHhzGnzbokDP7WO1t7qTLDAHqRq0lY929ulmgjfb Z4jRpfGXD9UkCu+1Do08Osty96rQ0F+Rlen8I3PQmFqGvYa+5/EStQ4ySqnYecXxUHw/ 7AgA== X-Gm-Message-State: ACrzQf2Y2Ui48Xka4KErtqHy7DTJY35nuBXon0NlUOi6CsrxRlzU0Fmh UhWmM3+W2TunI1q9aj16PYMuS56lyDsf3OXh X-Google-Smtp-Source: AMsMyM6bh+JglBZit6dWZjYjguvxjXAoF26XlD/Dk1fYeYV5JyiLsBQA35F1Gf3B3QRwkG4r/xng3Q== X-Received: by 2002:a67:e013:0:b0:398:54f:2078 with SMTP id c19-20020a67e013000000b00398054f2078mr4278148vsl.28.1664552020211; Fri, 30 Sep 2022 08:33:40 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c2:3736:5474:7f48:dc74:6616? ([2804:1b3:a7c2:3736:5474:7f48:dc74:6616]) by smtp.gmail.com with ESMTPSA id m12-20020a0561020ecc00b00397c028db51sm1474046vst.21.2022.09.30.08.33.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Sep 2022 08:33:39 -0700 (PDT) Message-ID: <89e56f54-f8c2-fd38-993e-51b520a2c97c@linaro.org> Date: Fri, 30 Sep 2022 12:33:37 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v5 2/3] linux: Fix ancillary 64-bit time timestamp conversion (BZ #28349, BZ#28350) Content-Language: en-US To: Arnd Bergmann , Xi Ruoyao References: <20220127201542.2306657-1-adhemerval.zanella@linaro.org> <20220127201542.2306657-3-adhemerval.zanella@linaro.org> <9a7585d4-45de-d957-f746-770bc2abf55e@linaro.org> <2eb53654-6374-41e2-b84d-908cd5b8f9ee@app.fastmail.com> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <2eb53654-6374-41e2-b84d-908cd5b8f9ee@app.fastmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 30/09/22 11:56, Arnd Bergmann wrote: > On Fri, Sep 30, 2022, at 3:46 PM, Adhemerval Zanella Netto via Libc-alpha wrote: >> On 30/09/22 10:09, Arnd Bergmann wrote: >>> On Fri, Sep 30, 2022, at 2:51 PM, Adhemerval Zanella Netto via Libc-alpha wrote: >>>> On 30/09/22 09:31, Szabolcs Nagy wrote: >>>>>> >>>>>> I used gcc 12.1.1, maybe it is a compiler issue? >>>>> >>>>> sorry it was my fault: old kernel headers. >>>> >>>> Right, but I am puzzled since it should not matter (at least glibc >>>> should handle it). >>>> What was miscompiled due wrong kernel header? >>> >>> Using SIOCGSTAMP/SIOCGSTAMPNS wtih 64-bit time_t requires kernel >>> headers after this 2019 commit: >>> >>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0768e17073dc52 >> >> But glibc does not use these definition internally or on tests. > > My mistake. SO_TIMESTAMPNS was a different commit, this is the one > you need then: > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=887feae36a > > Arnd Right, so if we need an update kernel to actually build and test glibc correctly I think it would be better to internally define SO_TIMESTAMPNS instead of rely on kernel headers.