licensing status for files without notice

licensing status for files without notice

[Christoph Hellwig]

Hi all,

what license are files in glibc under that do not have an explicit
copyright notice?

My practical case is that I have a test cased that reuses the general
structure and small amounts of code from tst-pselect.c, and I'd like
to keep the license and an attribution in tact.

Re: licensing status for files without notice

[Joseph Myers]

On Tue, 2 Jan 2018, Christoph Hellwig wrote:

> Hi all,
> 
> what license are files in glibc under that do not have an explicit
> copyright notice?

We should put a standard LGPL notice on any such files more than ten lines 
long.  (However, to get the copyright dates for an old file without a 
copyright notice it may be necessary to check history.git for when the 
file was actually created, because of problems with the coalescing of 
commits into subsequent ChangeLog commits in earlier history.)

-- 
Joseph S. Myers
joseph@codesourcery.com

Re: licensing status for files without notice

[Florian Weimer]

[-- Attachment #1: Type: text/plain, Size: 682 bytes --]

On 01/02/2018 07:29 PM, Joseph Myers wrote:
> On Tue, 2 Jan 2018, Christoph Hellwig wrote:
> 
>> Hi all,
>>
>> what license are files in glibc under that do not have an explicit
>> copyright notice?
> 
> We should put a standard LGPL notice on any such files more than ten lines
> long.  (However, to get the copyright dates for an old file without a
> copyright notice it may be necessary to check history.git for when the
> file was actually created, because of problems with the coalescing of
> commits into subsequent ChangeLog commits in earlier history.)

I think the ChangeLog files themselves are sufficiently accurate to 
determine the year of the change.

Thanks,
Florian

[-- Attachment #2: tst-pselect.patch --]
[-- Type: text/x-patch, Size: 1293 bytes --]

Subject: [PATCH] misc/tst-pselect.c: Add copyright header
To: libc-alpha@sourceware.org

The initial year is based on the date in the original ChangeLog entry
(2006-01-21).

2018-01-02  Florian Weimer  <fweimer@redhat.com>

	* misc/tst-pselect.c: Add copyright header.

diff --git a/misc/tst-pselect.c b/misc/tst-pselect.c
index 0d11a809a0..fc28d64238 100644
--- a/misc/tst-pselect.c
+++ b/misc/tst-pselect.c
@@ -1,3 +1,20 @@
+/* Copyright (C) 2006-2018 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Lesser General Public
+   License as published by the Free Software Foundation; either
+   version 2.1 of the License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public
+   License along with the GNU C Library; if not, see
+   <http://www.gnu.org/licenses/>.  */
+
 #include <errno.h>
 #include <signal.h>
 #include <stdio.h>

Re: licensing status for files without notice

[Joseph Myers]

On Tue, 2 Jan 2018, Florian Weimer wrote:

> On 01/02/2018 07:29 PM, Joseph Myers wrote:
> > On Tue, 2 Jan 2018, Christoph Hellwig wrote:
> > 
> > > Hi all,
> > > 
> > > what license are files in glibc under that do not have an explicit
> > > copyright notice?
> > 
> > We should put a standard LGPL notice on any such files more than ten lines
> > long.  (However, to get the copyright dates for an old file without a
> > copyright notice it may be necessary to check history.git for when the
> > file was actually created, because of problems with the coalescing of
> > commits into subsequent ChangeLog commits in earlier history.)
> 
> I think the ChangeLog files themselves are sufficiently accurate to determine
> the year of the change.

Yes, if the addition of such a file is mentioned in a ChangeLog, that can 
be used to determine the start year for the copyright range.

-- 
Joseph S. Myers
joseph@codesourcery.com

Re: licensing status for files without notice

[Carlos O'Donell]

On 01/02/2018 10:39 AM, Florian Weimer wrote:
> On 01/02/2018 07:29 PM, Joseph Myers wrote:
>> On Tue, 2 Jan 2018, Christoph Hellwig wrote:
>>
>>> Hi all,
>>>
>>> what license are files in glibc under that do not have an explicit
>>> copyright notice?
>>
>> We should put a standard LGPL notice on any such files more than ten lines
>> long.  (However, to get the copyright dates for an old file without a
>> copyright notice it may be necessary to check history.git for when the
>> file was actually created, because of problems with the coalescing of
>> commits into subsequent ChangeLog commits in earlier history.)
> 
> I think the ChangeLog files themselves are sufficiently accurate to determine the year of the change.
> 
> Thanks,
> Florian
> 
> tst-pselect.patch
> 
> 
> Subject: [PATCH] misc/tst-pselect.c: Add copyright header
> To: libc-alpha@sourceware.org
> 
> The initial year is based on the date in the original ChangeLog entry
> (2006-01-21).
> 
> 2018-01-02  Florian Weimer  <fweimer@redhat.com>
> 
> 	* misc/tst-pselect.c: Add copyright header.

LGTM.

Relevant ChangeLog was ChangeLog.old/ChangeLog.16.

Entry was for 2006-01-21, the file in question was created by Ulrich Drepper
while at Red Hat.

The git history is also accurate.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>

> diff --git a/misc/tst-pselect.c b/misc/tst-pselect.c
> index 0d11a809a0..fc28d64238 100644
> --- a/misc/tst-pselect.c
> +++ b/misc/tst-pselect.c
> @@ -1,3 +1,20 @@
> +/* Copyright (C) 2006-2018 Free Software Foundation, Inc.
> +   This file is part of the GNU C Library.
> +
> +   The GNU C Library is free software; you can redistribute it and/or
> +   modify it under the terms of the GNU Lesser General Public
> +   License as published by the Free Software Foundation; either
> +   version 2.1 of the License, or (at your option) any later version.
> +
> +   The GNU C Library is distributed in the hope that it will be useful,
> +   but WITHOUT ANY WARRANTY; without even the implied warranty of
> +   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> +   Lesser General Public License for more details.
> +
> +   You should have received a copy of the GNU Lesser General Public
> +   License along with the GNU C Library; if not, see
> +   <http://www.gnu.org/licenses/>.  */
> +
>  #include <errno.h>
>  #include <signal.h>
>  #include <stdio.h>


-- 
Cheers,
Carlos.