Re: [glibc PATCH] fcntl: put F_OFD_* constants under #ifdef __USE_FILE_OFFSET64

["Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>]

On 08/23/2016 11:38 PM, Cyril Hrubis wrote:
> Hi!
>> To be clear, that approach was NAK'ed by Christoph (and I think that's
>> a good thing, actually -- one more nail in the non-LFS coffin). I think
>> what we want merged into glibc is this patch that I sent late on
>> Thursday:
>>
>>     [glibc PATCHv2] fcntl: don't define OFD lock constants for 32-bit builds with small file offsets
>>
>> We'll also need your patch to the fcntl(2) manpage as well, but that's
>> a separate problem.
> 
> Hmm, the patch for man-pages should be updated as well. We need
> somethign as:
> 
> ...
> This lock  type  is  Linux-specific,  and  available since Linux 3.15.
> On 32bit platform _FILE_OFFSET_BITS must defined to 64 (before including
> any header files) to make these locks available.
> ...
> 
> Michael should I send updated patch or will you take care of this?

I can do it, or you can. At the moment, I'm just holding off until I 
see what is accepted into glibc.

Cheers,

Michael

-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/